Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Feature/348 container images - #553

Closed
MikeNeilson wants to merge 5 commits into
mainfrom
feature/348-container-images
Closed

Feature/348 container images#553
MikeNeilson wants to merge 5 commits into
mainfrom
feature/348-container-images

Conversation

@MikeNeilson

@MikeNeilson MikeNeilson commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

Provide docker compose for Postgres implementation to help get people started.
Will also create one for CWMS and the OpenDCS Oracle impl later.

... will also change the branch name later so it makes sense... it's late.

@MikeNeilson
MikeNeilson requested a review from krowvin September 25, 2025 03:36
@sonarqubecloud

Copy link
Copy Markdown

@krowvin krowvin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me!

Would also appreciate a .gitattributes with
*.sh text eol=lf

It will save me on Windows with the IDE defaulting to CLRF without it!

Also consider going ahead and adding a table of handy URL to the README (including the pgadmin page)

Comment thread docker-compose.pg.yaml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I cry lazy on this one (opinion)

Don't make folks specify a docker compose file with:
docker compose -f docker-compose.pg.yaml up

My opinion would be to create a standard docker file for testing and then an opt in one for additional tests. I imagine you eventually want one for oracle too.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I'll make a sym link. The idea is to have a compose for each implementation. They're different enough it doesn't make sense to try and have a shared file.

Bit of the curse of so much flexibility.

@MikeNeilson

Copy link
Copy Markdown
Collaborator Author

Closing as reusing the branch name was wrong and unintentional. See #554

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants