Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Initial javascript dependency cleanup. - #556

Merged
MikeNeilson merged 5 commits into
mainfrom
devops/setup-webjars-deps
Sep 27, 2025
Merged

Initial javascript dependency cleanup.#556
MikeNeilson merged 5 commits into
mainfrom
devops/setup-webjars-deps

Conversation

@MikeNeilson

Copy link
Copy Markdown
Collaborator

Problem Description

Fixes #.

Describe the problem you are trying to solve.

Solution

  • Setup all JavaSript dependencies as a https://Webjars.org dependency in gradle
  • Remove all javascript and css that required payment for usage or license otherwise does not allow our usage.

how you tested the change

Verified that limited behavior was valid:

  1. Login works
  2. Network tab of developer tools shows no 404 on required dependencies

As limitless was used for the sidebar and other elements, nothing currently renders correctly. This is intentional though I will attempt at least a basic replacement in this PR.

However, given the legal issues, I would rather merge this in with the warts that continue to otherwise provide/release something for which we likely do not hold the legal right to do so.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@MikeNeilson
MikeNeilson marked this pull request as ready for review September 26, 2025 22:17
@MikeNeilson

Copy link
Copy Markdown
Collaborator Author

Okay, there's definitely still several problems with the rendering due to the various removed css. Getting the library defaults back in-place helped with several elements but there is a lot that's still not right.

The sidebar especially. A boostrap sidebar extension was added which did help a bit, most of the css class names were valid but several things were removed and it wouldn't surprise if if some behavior was different from what was there.

To be blunt, it's not useable as-is, but only libraries and css we can legally redistribution is now included so that's a better overall situation as it's just the work to fix it.

I'm going to continue on today seeing if I can do that, but otherwise will merge in and just get back to it at some other time or others can pitch in.

@krowvin

krowvin commented Sep 26, 2025

Copy link
Copy Markdown

some other time or others can pitch in.

Do you prefer comments only on this PR or additional commits as well?

Or another branch based off this one?

@MikeNeilson

Copy link
Copy Markdown
Collaborator Author

Comments and PRs to this branch are both welcome. I will likely merge in over the weekend so there's time to get some initial things in. (currently tweaking the top navbar to newer bootstrap standards now. But will be done, working or not, in the next few minutes after typing this.)

@MikeNeilson

Copy link
Copy Markdown
Collaborator Author

okay, got nav working again.

bad news: still a bit ugly
good news: just using the updated deps a default css thereof we got every-other-column highlighting.

barring someone pointing out and unexpected issue will merge in this weekend. probably later today.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MikeNeilson
MikeNeilson merged commit ba466fd into main Sep 27, 2025
9 of 10 checks passed
@MikeNeilson
MikeNeilson deleted the devops/setup-webjars-deps branch September 27, 2025 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants