-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(rjy): add crowd md env new, and multi-head policy #230
base: main
Are you sure you want to change the base?
Conversation
fix(rjy): fix crowd env scale/add entropy info
…nto rjy-crowd-md-env-new
if observation_array.ndim == 3: | ||
# Flatten the last two dimensions | ||
observation_array = observation_array.reshape(batch_size, -1) | ||
else: | ||
raise ValueError("For 'mlp' model_type, the observation must have 3 dimensions [B, S, O]") | ||
|
||
elif model_type == 'rgcn': | ||
if observation_array.ndim == 4: | ||
# TODO(rjy): strage process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strage process是什么意思?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
解释一下'rgcn'下面各种情况的含义吧
lzero/model/common.py
Outdated
activation: Optional[nn.Module] = nn.ReLU(inplace=True), | ||
last_linear_layer_init_zero: bool = True, | ||
norm_type: Optional[str] = 'BN', | ||
self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash format.sh一下
lzero/model/common.py
Outdated
output_support_size: int = 601, | ||
last_linear_layer_init_zero: bool = True, | ||
activation: Optional[nn.Module] = nn.ReLU(inplace=True), | ||
norm_type: Optional[str] = 'BN', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些缩进还是换成原来的格式哈
""" | ||
Overview: | ||
Relational graph convolutional network layer. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
给一下这里代码实现的参考链接
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcn的实验我们有测试吗?还是只是测试了md的情况?gcn相对md的优点是?目前我们合到main里面的只放完整测试过的吧
zoo/CrowdSim/envs/CrowdSim_env.py
Outdated
@ENV_REGISTRY.register('crowdsim_lightzero') | ||
class CrowdSimEnv(BaseEnv): | ||
|
||
def __init__(self, cfg: dict = {}) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加overview注释
@ENV_REGISTRY.register('crowdsim_lightzero') | ||
class CrowdSimEnv(BaseEnv): | ||
|
||
def __init__(self, cfg: dict = {}) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
增加overview注释,将之前的文档中英文版本放在这里的envs/路径下面哈
|
||
|
||
@MODEL_REGISTRY.register('MuZeroModelMD') | ||
class MuZeroModelMD(nn.Module): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所有增加的文件都需要继承自已有的文件,以避免冗余代码哈,只重写修改过的method。例如这里需要继承自MuZeroModel。相应的注释也需要更新一下。
"nlon": 200, | ||
"nlat": 120, | ||
"human_num": 59, | ||
"dataset_dir": 'crowd_sim/dataset/purdue/59 users.csv', # TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里3种大学的 不同数量users.csv是什么含义?是作为环境设置的一部分吗?需要上传上去环境才能运行的吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个环境的代码是在哪篇论文和code上修改的呢
""" | ||
Overview: | ||
Relational graph convolutional network layer. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcn的实验我们有测试吗?还是只是测试了md的情况?gcn相对md的优点是?目前我们合到main里面的只放完整测试过的吧
|
||
@ENV_REGISTRY.register('crowdsim_lightzero') | ||
class CrowdSimEnv(BaseEnv): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个和crowdsim_env的区别是?应该只保留一个就好吧
…rowd-md-env-new
print(CL) | ||
|
||
|
||
# Maximum Coupling Loss (110dB is recommended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是什么含义?
New Environment: CrowdSim
Multi-Head Policy Version for MuZero, EfficientZero, and Sampled EfficientZero