-
Notifications
You must be signed in to change notification settings - Fork 78
chore: Add notification tray how-to #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
09edf1b to
f04d634
Compare
|
As part of this PR, could you link this how-to article at line 143 in https://github.com/openedx/docs.openedx.org/blob/main/source/community/release_notes/ulmo/ulmo_notifications.rst (where it currently says to look at the Operator release notes) |
| - Type: Boolean | ||
| - Default: ``True`` | ||
|
|
||
| When enabled, learners can opt in or out of receiving email notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this and the next option I'd want to know a bit more. Does disabling these mean that users can't get email or that they can't disable email pushes.
baca6a4 to
7f34bd3
Compare
|
@sarina @xitij2000 Please have a look I have made the changes here. |
sarina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two more comments but overall looks great. Will wait for @xitij2000 to give a 👍🏻 before I merge.
230fe8a to
20bfd68
Compare
20bfd68 to
3260b7e
Compare
|
@farhaanbukhsh apologies for last minute suggestions on this PR. I was out sick for the last 2 days. |
c594275 to
44b2819
Compare
@ayub02 I hope you are doing better. I don't see any suggestions on the PR. |
ayub02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies! I forgot to submit the review. Here it is.
| They span activities such as Discussions updates, Course updates, and Grading updates. | ||
|
|
||
| The **notification tray** allows learners to access platform notifications from | ||
| the top-right corner of the Open edX interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| the top-right corner of the Open edX interface. | |
| the top-right corner of the Open edX interface. **Notification emails** keep them updated when they are away from the platform. We do not have support for push notifications for Open edX mobile app at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use "Open edX", not "edX". Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected. Thanks.
|
|
||
| - Sets the required environment variables for the notifications service | ||
|
|
||
| - ``SHOW_EMAIL_CHANNEL`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - ``SHOW_EMAIL_CHANNEL`` | |
| - ``SHOW_EMAIL_CHANNEL`` (defaults to TRUE) |
| - Sets the required environment variables for the notifications service | ||
|
|
||
| - ``SHOW_EMAIL_CHANNEL`` | ||
| - ``SHOW_PUSH_CHANNEL`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - ``SHOW_PUSH_CHANNEL`` | |
| - ``SHOW_PUSH_CHANNEL`` (defaults to FALSE) |
| ********************************** | ||
|
|
||
| The notifications plugin exposes several configuration options that can be | ||
| customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_. | |
| customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_. These options are as follows: |
| - Default: ``False`` | ||
|
|
||
| When enabled, learners get toggle to opt in or out of push notifications. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. important:: | |
| The Open edX platform does not currently support push notifications for mobile apps. This toggle is added as part of ground work for when that support will be built. | |
| The notifications Tutor plugin does **not** provide built-in configuration for | ||
| cron jobs needed for email digests. However, the Open edX platform supports **daily and weekly | ||
| notification digests** through management commands. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. important:: | |
| Default preference for email notifications for all users is ``Daily``. Therefore, by default, users will not receive any notification emails unless this cron job is is configured. |
|
|
||
| .. code-block:: bash | ||
|
|
||
| 0 22 * * SUN tutor local run lms ./manage.py lms send_email_digest Weekly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 0 22 * * SUN tutor local run lms ./manage.py lms send_email_digest Weekly | |
| 0 22 * * FRI tutor local run lms ./manage.py lms send_email_digest Weekly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear most operators will just copy paste this line. And Sunday is not optimal for weekly emails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but Friday at 10pm is? That doesn't make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhaanbukhsh i agree that since defaults match the msg on accounts page, let's leave it as is.
I'm not sure about removing the message on accounts page because we don't have a a better alternate until Verawood.
@sarina you are right. The day is just my guess. 22:00 UTC had the highest activity on average on the 2U instance. That's where it came from. Open edX's user base is global and therefore we can't select an idea time. This is in phase 3, i'm proposing that we send these emails based on the user's timezone. But that needs some discovery which Ahtisham will do in the next few days.
| You can change the delivery time by modifying the cron schedule according to | ||
| your operational requirements. For example, `0 22 * * *` schedules the command to run everyday at **10:00 PM** | ||
| this can be modified to run at the hours/days of choice. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhaanbukhsh do you think we should add something on the deletion cron job? Or is this something instance operators are familiar with and can add on their own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blog link that is added covers a lot of information, so we can skip this
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
44b2819 to
617bf72
Compare

Description
The PR adds the instruction to configure and enable the notification tray and notification feature.
Useful information to include:
This is contingent on our publishing https://github.com/openedx/tutor-contrib-notifications on PyPI and changing the name to tutor-contrib-platform-notifications
Supporting information
Testing instructions
make requirementsmake serve_docsDeadline
Before Thursday (18/12/2025)
Other information
Private Ref: https://tasks.opencraft.com/browse/BB-10380