Skip to content

Conversation

@farhaanbukhsh
Copy link
Member

Description

The PR adds the instruction to configure and enable the notification tray and notification feature.

Useful information to include:

This is contingent on our publishing https://github.com/openedx/tutor-contrib-notifications on PyPI and changing the name to tutor-contrib-platform-notifications

Supporting information

Testing instructions

  • Pull this branch
  • make requirements
  • make serve_docs

Deadline

Before Thursday (18/12/2025)

Other information

Private Ref: https://tasks.opencraft.com/browse/BB-10380

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Dec 16, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @openedx/wg-maintenance-docs.openedx.org.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 16, 2025
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from 09edf1b to f04d634 Compare December 16, 2025 12:49
@sarina sarina moved this from Needs Triage to In Eng Review in Contributions Dec 16, 2025
@sarina
Copy link
Contributor

sarina commented Dec 16, 2025

As part of this PR, could you link this how-to article at line 143 in https://github.com/openedx/docs.openedx.org/blob/main/source/community/release_notes/ulmo/ulmo_notifications.rst (where it currently says to look at the Operator release notes)

- Type: Boolean
- Default: ``True``

When enabled, learners can opt in or out of receiving email notifications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and the next option I'd want to know a bit more. Does disabling these mean that users can't get email or that they can't disable email pushes.

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from baca6a4 to 7f34bd3 Compare December 17, 2025 12:56
@farhaanbukhsh
Copy link
Member Author

@sarina @xitij2000 Please have a look I have made the changes here.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two more comments but overall looks great. Will wait for @xitij2000 to give a 👍🏻 before I merge.

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from 230fe8a to 20bfd68 Compare December 17, 2025 19:12
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from 20bfd68 to 3260b7e Compare December 18, 2025 07:54
@ayub02
Copy link
Contributor

ayub02 commented Dec 18, 2025

@farhaanbukhsh apologies for last minute suggestions on this PR. I was out sick for the last 2 days.

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from c594275 to 44b2819 Compare December 18, 2025 13:52
@farhaanbukhsh
Copy link
Member Author

@farhaanbukhsh apologies for last minute suggestions on this PR. I was out sick for the last 2 days.

@ayub02 I hope you are doing better. I don't see any suggestions on the PR.

Copy link
Contributor

@ayub02 ayub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies! I forgot to submit the review. Here it is.

They span activities such as Discussions updates, Course updates, and Grading updates.

The **notification tray** allows learners to access platform notifications from
the top-right corner of the Open edX interface.
Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the top-right corner of the Open edX interface.
the top-right corner of the Open edX interface. **Notification emails** keep them updated when they are away from the platform. We do not have support for push notifications for Open edX mobile app at the moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use "Open edX", not "edX". Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thanks.


- Sets the required environment variables for the notifications service

- ``SHOW_EMAIL_CHANNEL``
Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``SHOW_EMAIL_CHANNEL``
- ``SHOW_EMAIL_CHANNEL`` (defaults to TRUE)

- Sets the required environment variables for the notifications service

- ``SHOW_EMAIL_CHANNEL``
- ``SHOW_PUSH_CHANNEL``
Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``SHOW_PUSH_CHANNEL``
- ``SHOW_PUSH_CHANNEL`` (defaults to FALSE)

**********************************

The notifications plugin exposes several configuration options that can be
customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_.
customized through the `Tutor configuration <https://docs.tutor.edly.io/configuration.html#configuration>`_. These options are as follows:

- Default: ``False``

When enabled, learners get toggle to opt in or out of push notifications.

Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. important::
The Open edX platform does not currently support push notifications for mobile apps. This toggle is added as part of ground work for when that support will be built.

The notifications Tutor plugin does **not** provide built-in configuration for
cron jobs needed for email digests. However, the Open edX platform supports **daily and weekly
notification digests** through management commands.

Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. important::
Default preference for email notifications for all users is ``Daily``. Therefore, by default, users will not receive any notification emails unless this cron job is is configured.


.. code-block:: bash

0 22 * * SUN tutor local run lms ./manage.py lms send_email_digest Weekly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
0 22 * * SUN tutor local run lms ./manage.py lms send_email_digest Weekly
0 22 * * FRI tutor local run lms ./manage.py lms send_email_digest Weekly

Copy link
Contributor

@ayub02 ayub02 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear most operators will just copy paste this line. And Sunday is not optimal for weekly emails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but Friday at 10pm is? That doesn't make sense to me.

Copy link
Member Author

@farhaanbukhsh farhaanbukhsh Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayub02, this is just documentation, hence the optimisation of the sending email will highly depend on the operator, so let's keep it as is. This also reflects what the message is shown by default on the account app

image

which reminds me that we should probably remove this

cc: @sarina

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh i agree that since defaults match the msg on accounts page, let's leave it as is.

I'm not sure about removing the message on accounts page because we don't have a a better alternate until Verawood.

@sarina you are right. The day is just my guess. 22:00 UTC had the highest activity on average on the 2U instance. That's where it came from. Open edX's user base is global and therefore we can't select an idea time. This is in phase 3, i'm proposing that we send these emails based on the user's timezone. But that needs some discovery which Ahtisham will do in the next few days.

You can change the delivery time by modifying the cron schedule according to
your operational requirements. For example, `0 22 * * *` schedules the command to run everyday at **10:00 PM**
this can be modified to run at the hours/days of choice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh do you think we should add something on the deletion cron job? Or is this something instance operators are familiar with and can add on their own.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog link that is added covers a lot of information, so we can skip this

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/how-to-enable-notification-tray branch from 44b2819 to 617bf72 Compare December 20, 2025 18:56
@farhaanbukhsh farhaanbukhsh requested a review from ayub02 December 20, 2025 19:03
@farhaanbukhsh
Copy link
Member Author

@sarina @ayub02 I have addressed all the comments

@sarina sarina merged commit 7faebd9 into main Dec 22, 2025
2 checks passed
@sarina sarina deleted the farhaan/how-to-enable-notification-tray branch December 22, 2025 13:09
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants