Skip to content

Conversation

@sarina
Copy link
Contributor

@sarina sarina commented Dec 15, 2025

@sarina sarina requested a review from ayub02 December 15, 2025 20:40
Copy link
Contributor

@ayub02 ayub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some small changes. Thanks for creating this PR.

@@ -0,0 +1,162 @@
.. _Ulmo Notifications:

Introducing Platform Notifications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Introducing Platform Notifications
Notifications For Learning Activity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayub02 - this is meant to be more of a marketing-focused note. I don't think your suggestion is as exciting/grabs attention as my suggestion. Would you like to suggest something more marketing-focused for this, if you don't like my suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Introducing Activity Notifications"? I think "Introducing Learning Activity Notifications" is a bit long.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this was marketing focused. Please proceed as you suggested. I changed it because i was looking for notifications in the list but took a few seconds to realize that notifications had 2 words before it.

reviewing activity, and understanding delivery settings, please refer to the
:ref:`Notifications & Preferences`.

For site operators, configuration options are available in the :ref:`Operator release notes <Ulmo operators>`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Change this link to the site ops how-to when #1360 is merged

Apply suggestions from code review

Co-authored-by: Aamir Ayub <40331925+ayub02@users.noreply.github.com>
@sarina sarina force-pushed the sarina/ulmo-notifications branch from e7fd51d to 1136cb9 Compare December 16, 2025 19:21
@sarina sarina enabled auto-merge (rebase) December 16, 2025 19:22
@sarina sarina merged commit 4477e4d into main Dec 16, 2025
2 checks passed
@sarina sarina deleted the sarina/ulmo-notifications branch December 16, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants