-
Notifications
You must be signed in to change notification settings - Fork 78
Add Notifications release note #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ayub02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some small changes. Thanks for creating this PR.
| @@ -0,0 +1,162 @@ | |||
| .. _Ulmo Notifications: | |||
|
|
|||
| Introducing Platform Notifications | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Introducing Platform Notifications | |
| Notifications For Learning Activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayub02 - this is meant to be more of a marketing-focused note. I don't think your suggestion is as exciting/grabs attention as my suggestion. Would you like to suggest something more marketing-focused for this, if you don't like my suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Introducing Activity Notifications"? I think "Introducing Learning Activity Notifications" is a bit long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know this was marketing focused. Please proceed as you suggested. I changed it because i was looking for notifications in the list but took a few seconds to realize that notifications had 2 words before it.
| reviewing activity, and understanding delivery settings, please refer to the | ||
| :ref:`Notifications & Preferences`. | ||
|
|
||
| For site operators, configuration options are available in the :ref:`Operator release notes <Ulmo operators>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Change this link to the site ops how-to when #1360 is merged
Apply suggestions from code review Co-authored-by: Aamir Ayub <40331925+ayub02@users.noreply.github.com>
e7fd51d to
1136cb9
Compare
Uh oh!
There was an error while loading. Please reload this page.