-
Notifications
You must be signed in to change notification settings - Fork 169
feat: add support for origin server and user info #2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for origin server and user info #2663
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2663 +/- ##
==========================================
+ Coverage 94.83% 94.85% +0.01%
==========================================
Files 1234 1232 -2
Lines 27764 27873 +109
Branches 6094 6133 +39
==========================================
+ Hits 26331 26439 +108
- Misses 1375 1376 +1
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| (restoreStatus.result.createdBy?.email && restoreStatus.result.createdOnServer) && ( | ||
| <div className="d-flex align-items-md-center gap-2"> | ||
| <Icon src={PersonOutline} style={{ width: '20px', height: '20px', marginRight: '8px' }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of inline styling for margin can we use bootstrap classes? like: 'mr-2'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks
holaontiveros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than th comment from Diana LGTM
diana-villalvazo-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
Before merge i will wait to see if @bradenmacdonald have some comments to add 😄 |
|
From a very quick look, this seems good, and I'm happy with the other reviews that were done here. Go ahead and merge :) |
* feat: add support for origin server and user info * test: add coverage for restore archive summary * test: increase coverage for restore archive summary * fix: address comments
Description
Resolves: #2596
This PR introduces the following improvements:
Before:
Now:
Where can I find this section?
This UI appears when creating a new V2 library using the “Create from archive” option.
Testing instructions
Other information
Related backend PR: openedx/edx-platform#37626
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'