-
Notifications
You must be signed in to change notification settings - Fork 170
feat: placeholder blocks for failed import blocks #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrisChV
merged 7 commits into
openedx:master
from
open-craft:navin/fal-4269/placeholder-blocks
Nov 27, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
86b8ade
feat: placeholder blocks for failed migration blocks
navinkarkera e01e865
fixup! feat: placeholder blocks for failed migration blocks
navinkarkera 93196f5
feat: add unsupported reason in placeholder block description
navinkarkera e80de42
feat: remove unsupported reason from description
navinkarkera bdc898d
chore: fix lint issues
navinkarkera 3533701
test: add tests
navinkarkera a593a5d
docs: add comments
navinkarkera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import BaseCard from '../components/BaseCard'; | ||
|
|
||
| interface PlaceHolderCardProps { | ||
| blockType: string; | ||
| displayName: string; | ||
| description?: string; | ||
| } | ||
|
|
||
| const PlaceholderCard = ({ blockType, displayName, description }: PlaceHolderCardProps) => { | ||
| const truncatedDescription = description ? `${description.substring(0, 40) }...` : undefined; | ||
| /* istanbul ignore next */ | ||
| return ( | ||
| <BaseCard | ||
| itemType={blockType} | ||
| displayName={displayName} | ||
| description={truncatedDescription} | ||
| tags={{}} | ||
| numChildren={0} | ||
| actions={null} | ||
| hasUnpublishedChanges={false} | ||
| onSelect={() => null} | ||
| selected={false} | ||
| isPlaceholder | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default PlaceholderCard; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.