-
Notifications
You must be signed in to change notification settings - Fork 182
feat: course outline header update [FC-0114] #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: course outline header update [FC-0114] #2823
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d858b3b to
3c2b8e0
Compare
rpenido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2823 +/- ##
=======================================
Coverage 95.07% 95.08%
=======================================
Files 1267 1267
Lines 29300 29313 +13
Branches 6492 6495 +3
=======================================
+ Hits 27858 27871 +13
Misses 1384 1384
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ChrisChV This is ready to be merged. |
|
@navinkarkera Sure! You need to fix the conflicts |
|
Hi @navinkarkera, friendly reminder to fix the conflicts to be able to merge this |
ed5b11c to
7b926be
Compare
|
@ChrisChV Thanks for the reminder! It is ready now. |
Description
Modifies new course outline header and actions as per #2622 (comment)
Note
The unpublished status badge doesn't appear automatically after any update to course item due to the way cache invalidation is setup with redux. I am in the process of moving parts of course outline data handling from redux to react-query in #2830, so this should be fixed soon.
Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4308Testing instructions
Verify the changes is as per #2622 (comment)
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'