feat: Make selectable component cards & Component Info Sidebar [FC-0114]#2880
feat: Make selectable component cards & Component Info Sidebar [FC-0114]#2880ChrisChV wants to merge 9 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2880 +/- ##
==========================================
+ Coverage 95.22% 95.24% +0.01%
==========================================
Files 1332 1335 +3
Lines 30551 30625 +74
Branches 6678 6923 +245
==========================================
+ Hits 29093 29168 +75
+ Misses 1401 1388 -13
- Partials 57 69 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Overall the changes look good.
Found one small issue: if the selected block is deleted, the sidebar should revert to unit info. Currently the block is still displayed in the sidebar.
Also, the add button on sidebar is disabled when a component is selected but the top level Add still works. I think disabling we should not disable the top level add button, instead if the author clicks on it the sidebar should revert to unit add. Currently it shows the add sidebar correctly but the component is still selected and shown in other tabs in the sidebar.
Description
Supporting information
Testing instructions
tutor dev exec cms npm run build-devManage tagsmenu in the unit card. Verify that the unit card is selected.Addbutton in the sidebar navbar is disabled.Manage tagsmenu in the component card. Verify that the component card is selected.Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'