Skip to content

feat: [FC-86] Updated Header links#12

Closed
PKulkoRaccoonGang wants to merge 2 commits intoopenedx:masterfrom
raccoongang:Peter_Kulko/updated-header-links-for-catalog-page
Closed

feat: [FC-86] Updated Header links#12
PKulkoRaccoonGang wants to merge 2 commits intoopenedx:masterfrom
raccoongang:Peter_Kulko/updated-header-links-for-catalog-page

Conversation

@PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jul 1, 2025

Description

This PR extends the frontend-component-header settings for the Index, Course Catalog, and Course About pages.

Initial setup

  1. Clone and install the tutor-mfe plugin from the draft PR that adds support for Catalog MFE.
  2. Go to http://apps.local.openedx.io:1998/catalog/courses

How Has This Been Tested?

The header for unauthenticated users has the following elements:

  • Logo
    / - link for Home page
    /learner-dashboard - link for Course about and Catalog pages
  • Explore courses link (/courses)
  • Sign Up button
  • Login button

The header for authenticated users has the following elements:

  • Logo
    / - link for Home page
    /learner-dashboard - link for Course about and Catalog pages
  • Courses link (/learner-dashboard)
  • /dashboard/programs - Programs
  • Programs link (/dashboard/programs)
  • Discover new link (/courses)
  • Help link

Marketing links

Will be provided via plugin slots (How it Works, Courses, Schools links) - openedx/frontend-component-header#598

Notes/Technical references

  • For the MFE Catalog pages we can use a similar approach to frontend-app-learner-dashboard with passing the necessary links directly to the frontend-component-header ()
  • Home route - /catalog/ (only Home page)
  • Discover new/Explore courses - link titles that change depending on whether the user is logged in or not
  • The link to Programs according to the Legacy template is only visible to authorized users
  • /learner-dashboard - link for Course about and Catalog pages, if the user is not authorized, a redirection occurs to the authorization page. First of all, the request occurs on the /dashboard, if MFE is enabled the user goes to /learner-dashboard, if not on the legacy /dashboard page (backend redirects).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 1, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jul 1, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Jul 1, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: Updated Header links feat: [FC-86] Updated Header links Jul 1, 2025
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

❌ Patch coverage is 97.29730% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.15%. Comparing base (2552216) to head (91babbc).

Files with missing lines Patch % Lines
src/index.tsx 50.00% 2 Missing ⚠️
src/header/hooks/useMenuItems.ts 96.42% 1 Missing ⚠️
src/home/HomePage.tsx 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   95.32%   96.15%   +0.83%     
==========================================
  Files          25       39      +14     
  Lines         171      312     +141     
  Branches       21       55      +34     
==========================================
+ Hits          163      300     +137     
- Misses          8       12       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

refactor: added tests

refactor: some refactoring

refactor: added tests for index.tsx

refactor: after review

fix: fixed tests

refactor: code refactoring
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/updated-header-links-for-catalog-page branch from 21afb14 to 91babbc Compare July 2, 2025 05:54
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jul 15, 2025
@PKulkoRaccoonGang
Copy link
Contributor Author

Reopened at raccoongang#18

@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants