feat: [FC-86] Updated Header links#12
feat: [FC-86] Updated Header links#12PKulkoRaccoonGang wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 95.32% 96.15% +0.83%
==========================================
Files 25 39 +14
Lines 171 312 +141
Branches 21 55 +34
==========================================
+ Hits 163 300 +137
- Misses 8 12 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
refactor: added tests refactor: some refactoring refactor: added tests for index.tsx refactor: after review fix: fixed tests refactor: code refactoring
21afb14 to
91babbc
Compare
|
Reopened at raccoongang#18 |
Note
Depend on #7
Related PR: openedx/frontend-component-header#598
Figma mockup
Description
This PR extends the frontend-component-header settings for the Index, Course Catalog, and Course About pages.
Initial setup
How Has This Been Tested?
The header for unauthenticated users has the following elements:
/- link for Home page/learner-dashboard- link for Course about and Catalog pages/courses)The header for authenticated users has the following elements:
/- link for Home page/learner-dashboard- link for Course about and Catalog pages/learner-dashboard)/dashboard/programs- Programs/dashboard/programs)/courses)Marketing links
Will be provided via plugin slots (How it Works, Courses, Schools links) - openedx/frontend-component-header#598
Notes/Technical references
/catalog/(only Home page)/learner-dashboard- link for Course about and Catalog pages, if the user is not authorized, a redirection occurs to the authorization page. First of all, the request occurs on the/dashboard, if MFE is enabled the user goes to/learner-dashboard, if not on the legacy/dashboardpage (backend redirects).Merge Checklist