feat: [FC-86] Added DataTable for Course Catalog page#31
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 96.96% 97.24% +0.28%
==========================================
Files 46 47 +1
Lines 362 363 +1
Branches 59 58 -1
==========================================
+ Hits 351 353 +2
+ Misses 11 10 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/catalog-page-datatable-component
branch
2 times, most recently
from
125361a to
a74f6f7
Compare
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/catalog-page-datatable-component
branch
from
a74f6f7 to
39b04a2
Compare
| })} | ||
| <Container className="container-xl pt-5.5 mb-6"> | ||
| <SubHeader | ||
| title={intl.formatMessage(messages.exploreCourses)} |
There was a problem hiding this comment.
[inform]: Changing the title according to search parameters (legacy functionality) will be added in PRs.
| itemCount={totalCourses} | ||
| initialState={{ pageSize: DEFAULT_PAGE_SIZE, pageIndex: DEFAULT_PAGE_INDEX }} | ||
| data={transformResultsForTable(courseData!.results)} | ||
| columns={[ |
There was a problem hiding this comment.
[inform]: The filtering logic for the DataTable will be added in upcoming PRs. For now, we’re focusing solely on building the UI.
PKulkoRaccoonGang
changed the title
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this looks great!
I left a couple comments with some small questions but this is super close to ready to merge!
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
This looks great!
Thank you so much for the detailed answers to my questions!
3 participants
Note
Dependencies:
Dependent PRs:
Important
The purpose of this PR is to introduce the necessary UI for the Course Catalog page. The filtering and search functionality will be implemented in upcoming PRs.
Description
A Paragon DataTable component has been added to the Course Catalog page to display course cards. Also added a Paragon Form.Control component that will be used for searching on this page.
Useful information
Figma design
Initial setup
tutor-mfeplugin from the draft PR that adds support for Catalog MFE.How Has This Been Tested?
http://apps.local.openedx.io:1998/catalog/courses).http://apps.local.openedx.io:1998/catalog/courses/<course_id>/about) without full page reloading (React Router).