feat: [FC-86] Added filtration for Catalog page#33
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 98.15% 98.45% +0.29%
==========================================
Files 73 75 +2
Lines 597 712 +115
Branches 82 114 +32
==========================================
+ Hits 586 701 +115
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/data/course-list-search/hooks.ts
Outdated
| import { | ||
| CourseListSearchResponse, CourseListSearchParams, CourseListSearchHook, DataTableParams, | ||
| } from './types'; |
There was a problem hiding this comment.
[question] Should we add type to declare the import type?
There was a problem hiding this comment.
Sure, added
7c60241 to
cae1faf
Compare
fix: corrected displayName for filters test: added tests refactor: tests refactoring refactor: after review
There was a problem hiding this comment.
I started a code review and left a couple minor comments, then I pulled the branch to test locally and I noticed a couple of issues.
Edit: The commit I tested for this review was cae1faf
Screencast.From.2025-10-17.09-20-06.mp4
- The checkboxes aren't getting checked
- The page is flashing a lot when filters are changed. I think one of the main reasons it is so noticeable is that the footer is moving. I think making sure the footer doesn't bounce up and down when the number of rows of result cards changes is definitely something we should address for this page.
|
After checking the Paragon docs site page for We should probably make a Paragon issue for better handling loading states in |
cae1faf to
632d372
Compare
632d372 to
30f0503
Compare
|
@brian-smith-tcril thanks!
I performed the following steps and didn’t encounter any issues with the checkboxes: After running
We already have an existing issue: openedx/paragon#2480 for this problem, as well as a PR: openedx/paragon#2846 that attempted to fix it. However, as far as I remember, it didn’t completely resolve the issue.
I think the situation will improve a bit once we have the footer fixed to the bottom and after the updates to the Paragon Date view component. It might also make sense to adjust the values of skeletonCardCount and DEFAULT_PAGE_SIZE to display more cards - both for the actual course list and the skeleton loaders. This way, we can improve the layout for cases where the platform has many courses, and the Date view will typically show two or three rows of cards (depending on the specific values set for |
|
UPD: @Serj-N also tried running the project locally on this branch, and he didn’t encounter any issues with the checkboxes either
|
|
@PKulkoRaccoonGang I pulled the latest version of this branch (30f0503) and the checkboxes are working as expected now! I'm thinking when I ran into the problem before it might have been a browser cache issue. |
Thanks for digging that up!
I 100% agree, fixing the footer to the bottom will definitely be a good short-term fix that will help quite a bit.
Definitely! Getting Paragon to a point where the image cap doesn't disappear/reappear when images are loading will be a huge UX win.
That definitely seems like something worth looking into at some point. Might be good to make an issue on this repo to investigate behavior with different values to find good defaults, but I think that can happen after this FC is closed out. |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
LGTM!
All of the UX issues I noticed in my reviews are documented as issues on the Paragon repo, so this is good to land!
Created a separate issue to track this problem: #41 |





Note
Dependencies:
frontend-app-catalog[FC-0086] openedx-platform#37130Dependent PRs:
Note
Search functionality will be added in the next PR.
Description
This PR adds course filtering for the Course Catalog page.
Useful information
Initial setup
tutor-mfeplugin from the draft PR that adds support for Catalog MFE.2, or create more than 20 coursesHow Has This Been Tested?
http://apps.local.openedx.io:1998/catalog/courses).