Skip to content

feat: [FC-86] Added plugin slots for the course about sidebar#62

Merged
brian-smith-tcril merged 3 commits intoopenedx:masterfrom
raccoongang:Peter_Kulko/course-about-plugin-slots
Nov 25, 2025
Merged

feat: [FC-86] Added plugin slots for the course about sidebar#62
brian-smith-tcril merged 3 commits intoopenedx:masterfrom
raccoongang:Peter_Kulko/course-about-plugin-slots

Conversation

@PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 20, 2025

Description

Added plugin-slots for Course About sidebar.

Useful information

Initial setup

  1. Clone and install the tutor-mfe plugin from the draft PR that adds support for Catalog MFE.
  2. Go to http://apps.local.openedx.io:1998/catalog/courses/<course_id>/about

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 20, 2025

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (26f4fb3) to head (43bf564).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   98.77%   98.78%           
=======================================
  Files          96       97    +1     
  Lines         981      986    +5     
  Branches      167      160    -7     
=======================================
+ Hits          969      974    +5     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: added plugin slots for the course about page feat: [FC-86] Added plugin slots for the course about page Nov 25, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: [FC-86] Added plugin slots for the course about page feat: [FC-86] Added plugin slots for the course about sidebar Nov 25, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/course-about-plugin-slots branch from ab2c449 to 199c3c5 Compare November 25, 2025 07:57
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 25, 2025 08:01
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 25, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Nov 25, 2025
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It'd be nice to add an example that uses the pluginProps, but I don't want to block this PR on that.

@brian-smith-tcril brian-smith-tcril merged commit 0720f73 into openedx:master Nov 25, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants