feat: [FC-86] Added plugin slots for catalog page#63
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 98.87% 98.95% +0.07%
==========================================
Files 97 105 +8
Lines 981 1055 +74
Branches 165 162 -3
==========================================
+ Hits 970 1044 +74
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8523910 to
382b412
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall these are looking great!
I left a few comments, looking forward to hearing your thoughts!
src/plugin-slots/CourseCatalogDataTableSlots/CourseCatalogDataTableSlot/index.tsx
Outdated
Show resolved
Hide resolved
src/plugin-slots/CourseCatalogDataTableSlots/CourseCatalogDataTableControlBarSlot/index.tsx
Outdated
Show resolved
Hide resolved
src/plugin-slots/CourseCatalogDataTableSlots/CourseCatalogDataTableCardViewSlot/README.md
Outdated
Show resolved
Hide resolved
...TableSlots/CourseCatalogDataTableCardViewSlot/CourseCatalogDataTableCourseCardSlot/README.md
Outdated
Show resolved
Hide resolved
63904cd to
eaf00aa
Compare
eaf00aa to
c584e15
Compare
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall looking great! Couple small things.
Description
Added plugin-slots for Course Catalog page.
Useful information
Initial setup
tutor-mfeplugin from the draft PR that adds support for Catalog MFE.