Skip to content

feat: [FC-86] Home page courses list#8

Closed
vladislavkeblysh wants to merge 2 commits intoopenedx:masterfrom
raccoongang:keblysh/feat/home-page-courses-list
Closed

feat: [FC-86] Home page courses list#8
vladislavkeblysh wants to merge 2 commits intoopenedx:masterfrom
raccoongang:keblysh/feat/home-page-courses-list

Conversation

@vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Jun 10, 2025

Note

This pull request depends on:

  1. Not found page
  2. Course catalog list
  3. Index Api
  4. Home page banner

Description

Implement courses list component

  1. Added courses list component with loading and empty state
  2. Added new api
  3. Added tests
  4. Refactor constants and urls
  5. Refactor course catalog data

How to testing it

  1. Create some courses
  2. Go to home page
  3. Ensure that courses list is displaying without crashing
  4. Ensure that LoadingSpinner is displaying if data is loading
  5. Ensure that error alert is displaying if response is error
  6. If courses list length more that homepage_course_max value - ensure that displayed courses list count equal homepage_course_max and View all courses button is displaying and on click redirect to courses page

Screenshot 2025-06-10 at 09 52 08

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 10, 2025
@vladislavkeblysh vladislavkeblysh self-assigned this Jun 10, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 10, 2025

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 98.22695% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.16%. Comparing base (b1a42de) to head (8cfaebe).

Files with missing lines Patch % Lines
src/generic/course-card/utils.ts 80.00% 1 Missing ⚠️
src/header/hooks/useMenuItems.ts 96.42% 1 Missing ⚠️
src/home/HomePage.tsx 95.00% 1 Missing ⚠️
src/home/components/courses-list/CoursesList.tsx 97.22% 1 Missing ⚠️
src/сatalog/CatalogPage.tsx 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   24.32%   96.16%   +71.84%     
===========================================
  Files           6       37       +31     
  Lines          37      313      +276     
  Branches        0       62       +62     
===========================================
+ Hits            9      301      +292     
+ Misses         28       12       -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladislavkeblysh vladislavkeblysh marked this pull request as draft June 10, 2025 07:48
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review June 10, 2025 10:00
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 12, 2025
@vladislavkeblysh vladislavkeblysh marked this pull request as draft June 16, 2025 08:59
@mphilbrick211 mphilbrick211 moved this from Ready for Review to Waiting on Author in Contributions Jun 20, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/home-page-courses-list branch from 8cfaebe to 25f9b01 Compare July 2, 2025 07:21
@vladislavkeblysh vladislavkeblysh changed the title feat: Home page courses list feat: [FC-86] Home page courses list Jul 2, 2025
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review July 2, 2025 07:22
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 15, 2025
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions Jul 15, 2025
@PKulkoRaccoonGang
Copy link
Contributor

Reopened at raccoongang#16

@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants