feat: added local translations for frontend-plugin-learner-dashboard #747
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 148 148
Lines 1302 1302
Branches 225 224 -1
=======================================
Hits 1270 1270
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajjibhai008
force-pushed
the
eahmadjaved/ENT-11106
branch
2 times, most recently
from
9c51c07 to
a3804da
Compare
jajjibhai008
force-pushed
the
eahmadjaved/ENT-11106
branch
from
a3804da to
f7900ed
Compare
Member
|
You can't add code to the open source repository in order to put local overrides from an edx-specific plugin into the committed source. Let's talk off-line, and come up with a solution that doesn't pollute the open source code base. |
deborahgu
requested changes
Nov 25, 2025
Member
deborahgu
left a comment
deborahgu
left a comment
There was a problem hiding this comment.
this isn't the right approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Implemented Solution] I solved the plugin translation issue by creating a custom solution for the frontend-plugin-learner-dashboard component since its translations aren't available in the remote repository. I set up a dedicated local-overrides folder to store the manually translated Spanish content, then modified the Makefile's pull_translations command to automatically copy these local translations into the main messages directory whenever official translations are pulled. Finally, I updated the application's i18n configuration to always use these local plugin translations, ensuring that our custom Spanish translations persist and are never overwritten by future translation updates, while still allowing the rest of the application to receive official translation updates normally.
JIRA -> ENT-11106