Skip to content

chore: update markdown dependency to allow newer versions #36735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 5 commits into from
May 27, 2025
Merged

chore: update markdown dependency to allow newer versions #36735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b1fc08
chore: update markdown dependency to allow newer versions
wgu-ram-chandra May 17, 2025
f39075c
Merge branch 'master' into issue-35271-unpin-markdown
wgu-ram-chandra May 17, 2025
b7a81cc
chore: trigger CI
wgu-ram-chandra May 17, 2025
d6bbb3e
Merge branch 'master' into issue-35271-unpin-markdown
wgu-ram-chandra May 20, 2025
6c29b79
Merge branch 'master' into issue-35271-unpin-markdown
wgu-ram-chandra May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lms/djangoapps/course_wiki/plugins/markdownedx/mdx_mathjax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ def handleMatch(self, m):


class MathJaxExtension(markdown.Extension):
def extendMarkdown(self, md, md_globals): # lint-amnesty, pylint: disable=arguments-differ, unused-argument
def extendMarkdown(self, md): # lint-amnesty, pylint: disable=arguments-differ, unused-argument
# Needs to come before escape matching because \ is pretty important in LaTeX
md.inlinePatterns.add('mathjax', MathJaxPattern(), '<escape')
md.inlinePatterns.register(MathJaxPattern(), 'mathjax', 180)


def makeExtension(**kwargs):
Expand Down
4 changes: 2 additions & 2 deletions lms/djangoapps/course_wiki/plugins/markdownedx/mdx_video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ def add_inline(self, md, name, klass, re): # pylint: disable=invalid-name
pattern = klass(re)
pattern.md = md
pattern.ext = self
md.inlinePatterns.add(name, pattern, "<reference")
md.inlinePatterns.register(pattern, name, 170)

def extendMarkdown(self, md, md_globals): # lint-amnesty, pylint: disable=arguments-differ, unused-argument
def extendMarkdown(self, md): # lint-amnesty, pylint: disable=arguments-differ, unused-argument
self.add_inline(md, 'bliptv', Bliptv,
r'([^(]|^)http://(\w+\.|)blip.tv/file/get/(?P<bliptvfile>\S+.flv)')
self.add_inline(md, 'dailymotion', Dailymotion,
Expand Down
6 changes: 0 additions & 6 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ edx-enterprise==5.13.7
# https://github.com/openedx/edx-platform/issues/31616
libsass==0.10.0

# Date: 2018-12-14
# markdown>=3.4.0 has failures due to internal refactorings which causes the tests to fail
# pinning the version untill the issue gets resolved in the package itself
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35271
markdown<3.4.0

# Date: 2024-07-16
# We need to upgrade the version of elasticsearch to atleast 7.15 before we can upgrade to Numpy 2.0.0
# Otherwise we see a failure while running the following command:
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,9 +719,8 @@ mako==1.3.10
# lti-consumer-xblock
# xblock
# xblock-utils
markdown==3.3.7
markdown==3.8
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/kernel.in
# openedx-django-wiki
# staff-graded-xblock
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,9 +1211,8 @@ mako==1.3.10
# lti-consumer-xblock
# xblock
# xblock-utils
markdown==3.3.7
markdown==3.8
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
# openedx-django-wiki
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,9 +869,8 @@ mako==1.3.10
# lti-consumer-xblock
# xblock
# xblock-utils
markdown==3.3.7
markdown==3.8
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
# openedx-django-wiki
# staff-graded-xblock
Expand Down
3 changes: 1 addition & 2 deletions requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,9 +925,8 @@ mako==1.3.10
# lti-consumer-xblock
# xblock
# xblock-utils
markdown==3.3.7
markdown==3.8
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
# openedx-django-wiki
# staff-graded-xblock
Expand Down
Loading