[DO NOT MERGE] chore!: replace pytz with zoneinfo#37148
Open
ttak-apphelix wants to merge 12 commits intoopenedx:masterfrom
Open
[DO NOT MERGE] chore!: replace pytz with zoneinfo#37148ttak-apphelix wants to merge 12 commits intoopenedx:masterfrom
ttak-apphelix wants to merge 12 commits intoopenedx:masterfrom
Conversation
ttak-apphelix
changed the title
jcapphelix
suggested changes
Aug 18, 2025
jcapphelix
left a comment
jcapphelix
left a comment
There was a problem hiding this comment.
I believe that this is a big change. It'd be difficult to review as well as test. So this can be broken down into multiple parts
What can be done instead is,
- Core changes go first
- Then we start by each app (i.e. lms,cms .. etc)
- Then with the
.htmlfiles (Which might be not needed as lots of files are being removed and replaced with MFEs) - And the last stage we remove
pytzdependency from requirements.
This will help in testing as well. Because testing these altogether is a bit difficult.
Also, there needs to be some discussion and some noise around this as well ? Because this change is something that is affecting whole platform. Tickets and DEPRs may exist around it, if so we can link those, if not we can start creating some noise around it. Basically this should not go as a whole without some discussion around it.
5 tasks
This was referenced Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore!: replace pytz with zoneinfo