Skip to content

Conversation

@ttqureshi
Copy link
Member

@ttqureshi ttqureshi commented Dec 10, 2025

It's the test PR for: openedx/xblocks-contrib#118

In this PR we are rolling out the follwowing Extracted XBlocks

  • Annotatable
  • Poll

by toggling their corresponding USE_EXTRACTED_<block_name>_BLOCK flags to True.
The following acceptance criteria should be tested on the Sandbox before merging this PR

Acceptance Criteria

  • Annotatable XBlock can be created in a V2 library, edited, published
  • Annotatable Xlock from a library can be used in a course, and its text can be overridden
  • XBlocks can be created in a course, edited, publislhed (special case for Poll, we need to import it from the OLX)
  • XBlocks block can be viewed in LMS
  • XBlocks import from OLX when it's a pointer tag
  • XBlocks import from OLX when it's inline
  • XBlocks export to OLX as a pointer tag
  • The exported course should be same as the course when BuiltIn XBlock is enabled

TODO:

  • Remove the fail-fast: false setting in unit-tests.yml before merging.

@openedx-webhooks
Copy link

openedx-webhooks commented Dec 10, 2025

Thanks for the pull request, @ttqureshi!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 10, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 10, 2025
@ttqureshi ttqureshi changed the title Enable the Extracted XBlocks Enable the Extracted XBlocks (WordCloud, Annotatable, Poll) Dec 10, 2025
@ttqureshi ttqureshi self-assigned this Dec 10, 2025
@ttqureshi ttqureshi added the create-sandbox A test sandbox will be created for this PR, using the `open-craft/pr-sandbox-automation` tool label Dec 10, 2025
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-extracted-xblocks branch from b2d399f to 248fa5a Compare December 10, 2025 06:02
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-extracted-xblocks branch from 7bfdd92 to a12a9d6 Compare December 10, 2025 07:57
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-extracted-xblocks branch from a12a9d6 to d9039be Compare December 10, 2025 08:01
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan marked this pull request as draft December 10, 2025 13:57
@farhan
Copy link
Contributor

farhan commented Dec 10, 2025

Converted to draft as redirecting to xblocks-contrib package from github to pypi is pending.

@farhan farhan marked this pull request as ready for review December 11, 2025 12:27
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ttqureshi ttqureshi changed the title Enable the Extracted XBlocks (WordCloud, Annotatable, Poll) Enable the Extracted XBlocks (Annotatable, Poll) Dec 16, 2025
@ttqureshi
Copy link
Member Author

We've identified a bug in the Extracted WordCloud XBlock during it's final testing before enabling. The issue is related to the editing of WordCloud in a content library V2.
I have created an issue and mentioned the steps to reproduce it.

After having a discussion with @farhan we have planned to enable the Annotatable and Poll XBlocks for the time being and enable the WordCloud later once this issue is fixed.

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ttqureshi ttqureshi force-pushed the ttqureshi/enable-extracted-xblocks branch 2 times, most recently from 2546de9 to c92bab1 Compare December 16, 2025 09:17
- remove the xblocks-contrib version pinning
- disable the Extracted WordCloud Block flag
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-extracted-xblocks branch from c92bab1 to 66eb119 Compare December 16, 2025 09:26
@farhan
Copy link
Contributor

farhan commented Dec 16, 2025

@ttqureshi Please confirm you have done the Acceptance Criteria testing for both Annotatable and Poll Xblocks?

@ttqureshi
Copy link
Member Author

ttqureshi commented Dec 16, 2025

Please confirm you have done the Acceptance Criteria testing for both Annotatable and Poll Xblocks?

@farhan
yes I have tested both XBlocks against all acceptance criteria and they are working as expected.

@farhan farhan merged commit 24cb3cf into openedx:master Dec 16, 2025
65 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Dec 16, 2025
@farhan farhan mentioned this pull request Dec 17, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox A test sandbox will be created for this PR, using the `open-craft/pr-sandbox-automation` tool open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants