-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Enable the Extracted XBlocks (Annotatable, Poll) #37740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the Extracted XBlocks (Annotatable, Poll) #37740
Conversation
|
Thanks for the pull request, @ttqureshi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
- enable extracted xblocks
b2d399f to
248fa5a
Compare
7bfdd92 to
a12a9d6
Compare
a12a9d6 to
d9039be
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Converted to draft as redirecting to xblocks-contrib package from github to pypi is pending. |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
We've identified a bug in the Extracted WordCloud XBlock during it's final testing before enabling. The issue is related to the editing of WordCloud in a content library V2. After having a discussion with @farhan we have planned to enable the Annotatable and Poll XBlocks for the time being and enable the WordCloud later once this issue is fixed. |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
2546de9 to
c92bab1
Compare
- remove the xblocks-contrib version pinning - disable the Extracted WordCloud Block flag
c92bab1 to
66eb119
Compare
|
@ttqureshi Please confirm you have done the Acceptance Criteria testing for both Annotatable and Poll Xblocks? |
@farhan |
It's the test PR for: openedx/xblocks-contrib#118
In this PR we are rolling out the follwowing Extracted XBlocks
by toggling their corresponding
USE_EXTRACTED_<block_name>_BLOCKflags toTrue.The following acceptance criteria should be tested on the Sandbox before merging this PR
Acceptance Criteria
TODO:
fail-fast: falsesetting inunit-tests.ymlbefore merging.