-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: [AXM-2307] add management command to backfill ContentDate model… #37989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: [AXM-2307] add management command to backfill ContentDate model… #37989
Conversation
… with existing assignments
|
Thanks for the pull request, @kyrylo-kh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| ) | ||
| except ItemNotFoundError: | ||
| log.warning(f"Course not found in modulestore: {course_key}") | ||
| return 0, 0, 0, 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps make it default tuple a variable.
|
|
||
| staff_user = User.objects.filter(is_staff=True).first() | ||
| if not staff_user: | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should return a tuple.
| self.stdout.write( | ||
| f"Processing assignment: {assignment.block_key}/{assignment.assignment_type} (due: {assignment.date})" | ||
| ) | ||
| existing = when_models.ContentDate.objects.filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why check existing before checking if this is a forced update? If preserving the existing records is important, I'm not sure it is, I think you should fetch all existing records into the local data structure and check against it.
| for i in range(0, len(assignments), self.batch_size): | ||
| batch = assignments[i: i + self.batch_size] | ||
|
|
||
| with transaction.atomic(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be around all the batches instead?
| self.force_update = options["force_update"] | ||
| self.batch_size = options["batch_size"] | ||
|
|
||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get the logger above at line 20, what is this for?
| updated = 0 | ||
| skipped = 0 | ||
|
|
||
| for assignment in assignments: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unchecked arg assignments.
| """ | ||
|
|
||
| help = "Extract assignment dates from modulestore and populate ContentDate table" | ||
| dry_run = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a mix of defaults here and in the add_argument section. Is anything needed beyond what you already have in hand()?
… with existing assignments
Description
This PR adds a new Django management command
seed_content_datesthat extracts assignment due dates from the modulestore and populates theContentDatetable in theedx-whenservice.Key Features
python manage.py lms seed_content_datesContentDatefrom course assignments in the modulestore.Options
--course-id: Seed a specific course.--org: Seed all courses for a specific organization.--dry-run: Simulate processing without writing to the database.--force-update: Overwrite existingContentDaterecords instead of skipping.--batch-size: Process assignments in batches (default: 100).Example Usage