Skip to content

VideoBlock code Optimization/Correction #38012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farhan merged 1 commit into from
Feb 17, 2026
Merged

VideoBlock code Optimization/Correction #38012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xmodule/video_block/video_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@
EXPORT_IMPORT_STATIC_DIR = 'static'


@XBlock.wants('settings', 'completion', 'i18n', 'request_cache', 'video_config')
@XBlock.needs('mako', 'user')
@XBlock.wants('settings', 'completion', 'request_cache', 'video_config')
@XBlock.needs('mako', 'user', 'i18n')
class _BuiltInVideoBlock(
VideoFields, VideoTranscriptsMixin, VideoStudioViewHandlers, VideoStudentViewHandlers,
EmptyDataRawMixin, XmlMixin, EditingMixin, XModuleToXBlockMixin,
Expand Down Expand Up @@ -265,7 +265,7 @@ def public_view(self, context):

Copy link
Contributor

@salman2013 salman2013 Feb 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhan public_view actually return the view seen by users who aren't logged in or who aren't enrolled in the course.(anonymous users)

Can you figure out how to test this because the testing results you shared are for student_view

I found this doc how to enable public course
https://docs.openedx.org/en/latest/site_ops/how-tos/enable_public_course_content.html

Copy link
Contributor Author

@farhan farhan Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on both the sandbox and my local setup (tutor dev), but I wasn’t able to load the Video block in incognito mode as a logged-out user.

@kdmccormick, do you know whether the Video public view access feature is currently working?

Copy link
Contributor Author

@farhan farhan Feb 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems feature is breaking while shifting to the mfes.
I managed to fix it via vibe coding/cursor and created test PR with the generated code.

After the fix, here is the preview:

Screenshot

With vibed fixing code and reverting line from
add_webpack_js_to_fragment(fragment, 'VideoBlockDisplay')
to
add_webpack_js_to_fragment(fragment, 'VideoBlockMain')
for the testing of the issue, here is the screen shot:

Screenshot

Copy link
Contributor

@salman2013 salman2013 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhan I don't think we need this fix PR, as i found where this was changed previously Ref I believe VideoBlockMain did not exist earlier.

fragment = Fragment(self.get_html(view=PUBLIC_VIEW, context=context))
add_css_to_fragment(fragment, 'VideoBlockDisplay.css')
add_webpack_js_to_fragment(fragment, 'VideoBlockMain')
add_webpack_js_to_fragment(fragment, 'VideoBlockDisplay')
fragment.initialize_js('Video')
return fragment

Expand Down
Loading