Skip to content

feat: pdf editor authoring flag#38148

Open
Kelketek wants to merge 1 commit intoopenedx:masterfrom
open-craft:fox/pdf-editor
Open

feat: pdf editor authoring flag#38148
Kelketek wants to merge 1 commit intoopenedx:masterfrom
open-craft:fox/pdf-editor

Conversation

@Kelketek
Copy link
Contributor

@Kelketek Kelketek commented Mar 10, 2026

Description

This merge request adds a waffle flag for toggling the new PDF editor in the authoring MFE, and also signals to the authoring frontend to use the new interface as applicable.

Supporting information

This is part of https://openedx.atlassian.net/wiki/spaces/OEPM/pages/5335908397/Proposal+Add+PDF+Block+to+Base+Installation

Testing instructions

  1. Set up this branch of xblocks-contrib to get an MFE editing-compatible version of the PDF Block
  2. Set up this branch of frontend-authoring to get the PDF editing tool in the MFE
  3. Add "pdf" to your list of advanced modules for a course in studio
  4. Add a PDF block and customize it.
  5. Save the block
  6. Use the edit button to edit the block settings.
  7. Add the waffle flag legacy_studio.pdf_editor and set it to enabled globally.
  8. Refresh the unit authoring page and hit the edit button on the XBlock. The old authoring interface should appear.

Dependencies

Must be merged BEFORE THIS PR: openedx/frontend-app-authoring#2916
Must be merged BEFORE THIS PR: openedx/xblocks-contrib#193

Deadline

Must be merged in time for Verawood

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 10, 2026

Thanks for the pull request, @Kelketek!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 10, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 10, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 11, 2026
@Kelketek Kelketek marked this pull request as ready for review March 12, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

2 participants