-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: introduce authz_permission_required decorator #38156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwong2708
wants to merge
8
commits into
openedx:master
Choose a base branch
from
WGU-Open-edX:dwong2708/new-permissions-checklists
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+526
−6
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
959d5d1
feat: introduce authz_permission_required decorator
dwong2708 165a759
fixup! feat: introduce authz_permission_required decorator
dwong2708 86a6f97
fixup! feat: introduce authz_permission_required decorator
dwong2708 2113e37
fixup! feat: introduce authz_permission_required decorator
dwong2708 4fe15cf
fixup! feat: introduce authz_permission_required decorator
dwong2708 582c8bc
fixup! feat: introduce authz_permission_required decorator
dwong2708 b6a8ec7
fixup! feat: introduce authz_permission_required decorator
dwong2708 45d595c
fixup! feat: introduce authz_permission_required decorator
dwong2708 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| """Django app configuration for authz app.""" | ||
|
|
||
| from django.apps import AppConfig | ||
|
|
||
|
|
||
| class AuthzConfig(AppConfig): | ||
mariajgrimaldi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| """Django application configuration for the Open edX Authorization (AuthZ) app. | ||
|
|
||
| This app provides a centralized location for integrations with the | ||
| openedx-authz library, including permission helpers, decorators, | ||
| and other utilities used to enforce RBAC-based authorization across | ||
| the platform.""" | ||
|
|
||
| default_auto_field = 'django.db.models.BigAutoField' | ||
| name = 'openedx.core.djangoapps.authz' | ||
| verbose_name = "Open edX Authorization Framework" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||
| """Constants used by the Open edX Authorization (AuthZ) framework.""" | ||||||
|
|
||||||
| from common.djangoapps.student.auth import has_studio_read_access, has_studio_write_access | ||||||
| from openedx.core.lib.teams_config import Enum | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd avoid importing from other apps unless necessary like in L3:
Suggested change
|
||||||
|
|
||||||
|
|
||||||
| class LegacyPermission(Enum): | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe more specific would be better, also adding a docstring would be useful as well.
Suggested change
|
||||||
| READ = "read" | ||||||
| WRITE = "write" | ||||||
|
|
||||||
|
|
||||||
| LEGACY_PERMISSION_HANDLER_MAP = { | ||||||
| LegacyPermission.READ: has_studio_read_access, | ||||||
| LegacyPermission.WRITE: has_studio_write_access, | ||||||
| } | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a non-staff user? Is this tested anywhere else?