Skip to content

fix: Can't delete unit from Library v2#38161

Open
ChrisChV wants to merge 4 commits intoopenedx:masterfrom
open-craft:chris/fix-cannot-delete-unit
Open

fix: Can't delete unit from Library v2#38161
ChrisChV wants to merge 4 commits intoopenedx:masterfrom
open-craft:chris/fix-cannot-delete-unit

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Mar 12, 2026

Description

  • Fixes the issue described in: https://discuss.openedx.org/t/cant-delete-unit-from-library-v2/18551/4 in two ways:
  • The error occurs because when copying a unit containing a component with a file, an error is generated midway through the process. However, each item (container/component) is created in the search index after being created in the database. If the operation fails, the database performs a rollback, but the search index does not.
  • First fix: Send the signals to create an entry in the index after the on commit of the transaction.
  • Second fix: When the item does not exist in the database, it deletes the record in the search index to keep it synchronized. (To allow deletion of broken items)
  • Which edX user roles will this change impact? "Course Author".

Supporting information

Testing instructions

  • Inside a unit, create a text with an image.
  • Copy the unit.
  • Paste the unit in a content library.
  • Verify that the operations end in error, but any item is created in the library.

Deadline

ASAP

Other information

This same error can occur in other operations if intermediate transaction errors are generated. TODO: Add the same fix to signal calls in openedx/core/djangoapps/content_libraries/api/blocks.py and openedx/core/djangoapps/content_libraries/api/containers.py

There may be cases where entries are created in the
search index, but the component/container is not created
(an intermediate error occurred). In that case, we added a fix to keep the index updated
by removing the entry.
- Only in: set_library_block_olx, _import_staged_block, create_container
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 12, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV ChrisChV changed the title Fix: Can't delete unit from Library v2 fix: Can't delete unit from Library v2 Mar 12, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 12, 2026
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 12, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants