Fix Python and JavaScript (Karma) tests for Problem XBlock #151

irtazaakram · 2026-02-03T05:44:49Z

Summary

This PR fixes the Python and JavaScript (Karma) tests for the newly extracted Problem (CAPA) XBlock.

Context

Extraction PR: Adds Problem XBlock extracting from edx-platform repo #63
Platform Enablement PR: Test PR | Enable Extracted Problem XBlock openedx-platform#37136

What Changed

Python Tests: Fixed import paths and module references in tests/ to align with the new directory structure.
Javascript Tests: Added Karma configuration and Webpack config.
Setup: Changed how xblocks-contribute is installed by requiring npm build.

Notes

Pylint cleanup and documentation updates are out of scope for this PR and will be addressed in a follow-up contribution.
The primary goal of this PR is to get the test suite green to unblock integration.

.github/workflows/javascript-tests.yml

salman2013 · 2026-02-06T10:01:19Z

.github/workflows/pypi-publish.yml

+
+    - name: Build JavaScript bundles
+      run: |
+        npm install


same as above comment.
https://github.com/openedx/xblocks-contrib/pull/151/changes#r2773284533

I added the npm run build step because the package requires the bundled JavaScript and CSS files in the public folder for the problem XBlock. These assets aren’t stored in the repo (public is gitignored) and are only supposed to be included in the published PyPi package.

xblocks_contrib/problem/assets/webpack.config.js

package.json

kdmccormick

I'm still working through the review, here are my comments so far

kdmccormick · 2026-02-09T14:13:37Z

xblocks_contrib/problem/capa/xqueue_interface.py

+try:
+    from openedx.core.djangoapps.waffle_utils import CourseWaffleFlag


Instead of bringing this flag in here, I think we should add this function the XQueueService, and then ensure that the service is available in LMS. The implementation in openedx-platform would check the waffle flag, and on the xblocks-contrib side, we would just do something like self.service(self, 'xqueue').use_edx_submissions_for_queue().

If you don't want to do that refactor as part of this PR, that makes sense--it would be good to get this PR merged in soon since it's so big. But I would like to remove this import before we enable the block in openedx-platform.

cc'ing @farhan, as has experience moving methods into XBlock services from the Video extraction work.

Just studied XQueueService, it seems like we are going to create new XBlock service in the edx-platform naming 'xqueue` for this waffle flag, is it correct? @kdmccormick

.github/workflows/javascript-tests.yml

MANIFEST.in

xblocks_contrib/problem/assets/webpack.config.js

xblocks_contrib/problem/tests/__init__.py

xblocks_contrib/problem/tests/test_capa_block.py

farhan · 2026-02-09T15:40:03Z

xblocks_contrib/problem/capa_block.py

-    FEATURES = getattr(settings, "FEATURES", {})
-except ImproperlyConfigured:
-    FEATURES = {}
+class InheritanceKeyValueStore(KeyValueStore):


Can we try avoid its definition and use xblock/runtime.py:DictKeyValueStore directly from xblock package as we are not using inherited_settings of InheritanceKeyValueStore in its usage.

farhan · 2026-02-09T15:45:59Z

xblocks_contrib/problem/capa_block.py

+
+        return xblock
+
+    @property


We can create a separate mixin like we did in video block here; also avoid usage of name xmodule

farhan · 2026-02-09T15:50:10Z

xblocks_contrib/problem/capa_block.py

+                f"Unable to create xml for block {self.location}. "
+                f"Context: '{lines[line - 1][offset - 40 : offset + 40]}'"
+            )
+            raise ValueError(msg) from err


I think its better to define SerializationError keeping it in sync with source code.

farhan · 2026-02-09T15:58:57Z

xblocks_contrib/problem/capa_block.py

+        return block
+
+    @classmethod
+    def parse_xml(cls, node, runtime, keys):


@ttqureshi Can you please review this parse_xml method?

comparing
https://github.com/openedx/openedx-platform/blob/master/xmodule/xml_block.py#L309

irtazaakram changed the title ~~fix: python & javascript tests~~ Fix Python and JavaScript (Karma) tests for Problem Xblock Feb 3, 2026

irtazaakram changed the title ~~Fix Python and JavaScript (Karma) tests for Problem Xblock~~ Fix Python and JavaScript (Karma) tests for Problem XBlock Feb 3, 2026

irtazaakram self-assigned this Feb 3, 2026

irtazaakram moved this to 👀 In review in Aximprovements Team Feb 3, 2026

irtazaakram added this to Aximprovements Team Feb 3, 2026

irtazaakram force-pushed the fix-problemblock branch 2 times, most recently from 3c433b8 to e0497fd Compare February 3, 2026 14:33

irtazaakram mentioned this pull request Feb 4, 2026

Fix Quality and Docs tests for Problem XBlock #153

Open

kdmccormick self-requested a review February 4, 2026 14:16

salman2013 requested changes Feb 6, 2026

View reviewed changes

kdmccormick reviewed Feb 9, 2026

View reviewed changes

fix: add problem xblock

c52b875

irtazaakram force-pushed the fix-problemblock branch from 9c42194 to c52b875 Compare February 9, 2026 14:30

farhan requested changes Feb 9, 2026

View reviewed changes

MANIFEST.in Outdated Show resolved Hide resolved

xblocks_contrib/problem/assets/webpack.config.js Show resolved Hide resolved

xblocks_contrib/problem/tests/__init__.py Outdated Show resolved Hide resolved

xblocks_contrib/problem/tests/test_capa_block.py Outdated Show resolved Hide resolved

irtazaakram added 2 commits February 9, 2026 19:36

fix: npm commands

c58c32b

fix: remove xmodule refrences

9a1a01c

farhan requested changes Feb 9, 2026

View reviewed changes

		try:
		from openedx.core.djangoapps.waffle_utils import CourseWaffleFlag

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

Are you sure you want to change the base?

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

Uh oh!

Conversation

irtazaakram commented Feb 3, 2026

Summary

Context

What Changed

Notes

Uh oh!

Uh oh!

salman2013 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

irtazaakram Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kdmccormick left a comment

Choose a reason for hiding this comment

Uh oh!

kdmccormick Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

farhan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

farhan Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

farhan Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

farhan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

farhan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

farhan Feb 9, 2026 •

edited

Loading

farhan Feb 9, 2026 •

edited

Loading