Skip to content

Conversation

@salman2013
Copy link
Contributor

@salman2013 salman2013 commented Feb 9, 2026

Description:

In this PR we bundled all discussion block's JS files into one JS file with webpack. Load the bundled file with resource url method which will optimized the files loading in browser.

Ticket: openedx/public-engineering#480

Testing Results:

Note: These screenshots are the testing results on local environment.

Screenshot 2026-02-11 at 11 49 36 AM Screenshot 2026-02-11 at 11 45 56 AM Screenshot 2026-02-11 at 11 46 11 AM Screenshot 2026-02-11 at 11 46 28 AM

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Feb 9, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 9, 2026

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@salman2013 salman2013 force-pushed the salman/discussion-block-webpack branch from 5f460f1 to 636c16c Compare February 10, 2026 11:57
@salman2013 salman2013 requested a review from a team February 10, 2026 12:01
@salman2013 salman2013 marked this pull request as ready for review February 10, 2026 12:01
@salman2013 salman2013 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 11, 2026
@salman2013 salman2013 removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

2 participants