[WIP] Add missing attr /system/function/{functionName} #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update swagger file to include attributes present in the POST endpoint but missing in the GET Relates to: openfaas#848 Signed-off-by: Edward Wilde <[email protected]>
|
Is this PR still valid? Do we want to test it? |
alexellis
reviewed
Jun 19, 2019
| @@ -402,6 +402,9 @@ definitions: | |||
| cpu: | |||
| type: string | |||
| example: "0.01" | |||
| readOnlyRootFilesystem: | |||
There was a problem hiding this comment.
We can add readOnlyRootFilesystem before finishing this WIP PR.
@ewilde Please could you or your colleague raise a PR for the readOnlyRootFilesystem part of this?
There was a problem hiding this comment.
@alexellis i'm no longer working on this PR, so going to close. @ameier38 is picking this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
Update swagger file and
Functiontype to add attributes missing from the /system/function/{functionName} GET endpointRelates to: #848
Motivation and Context
Mirroring POST/GET attributes makes API easier to use and integrate with other systems
How Has This Been Tested?
TBD
Types of changes
Checklist:
git commit -s