Skip to content

EvalSumRowsKeyGen() should return the native type instead of py::dict #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yspolyakov merged 1 commit into from
Mar 19, 2026
Merged

EvalSumRowsKeyGen() should return the native type instead of py::dict #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/lib/bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,11 +760,7 @@ void bind_crypto_context(py::module &m) {
const PrivateKey<DCRTPoly> privateKey,
uint32_t rowSize,
uint32_t subringDim) {
auto m = self.EvalSumRowsKeyGen(privateKey, rowSize, subringDim);
py::dict d;
for (const auto& [k, v] : *m)
d[py::int_(k)] = v;
return d;
return self.EvalSumRowsKeyGen(privateKey, rowSize, subringDim);
},
py::arg("privateKey"),
py::arg("rowSize") = 0,
Expand All @@ -776,16 +772,13 @@ void bind_crypto_context(py::module &m) {
const PublicKey<DCRTPoly> publicKey,
uint32_t rowSize,
uint32_t subringDim) {
auto m = self.EvalSumRowsKeyGen(privateKey, publicKey, rowSize, subringDim);
py::dict d;
for (const auto& [k, v] : *m)
d[py::int_(k)] = v;
return d;
return self.EvalSumRowsKeyGen(privateKey, publicKey, rowSize, subringDim);
},
py::arg("privateKey"),
py::arg("publicKey"),
py::arg("rowSize") = 0,
py::arg("subringDim") = 0)
py::arg("subringDim") = 0,
py::doc(cc_EvalSumRowsKeyGen_docs))
// TODO (Oliveira, R.): Solve pointer handling bug when dealing with EvalKeyMap object for the next functions
.def("EvalSumColsKeyGen", &CryptoContextImpl<DCRTPoly>::EvalSumColsKeyGen,
py::arg("privateKey"),
Expand Down
Loading