Skip to content

Conversation

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Nov 18, 2025

HAT only executes correctly with a Babylon JDK exploded build, and fails with an images build.

We need to declare the runtime argument --add-modules jdk.incubator.code.

Also removed an --add-exports argument which no longer seems to be required.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/684/head:pull/684
$ git checkout pull/684

Update a local copy of the PR:
$ git checkout pull/684
$ git pull https://git.openjdk.org/babylon.git pull/684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 684

View PR using the GUI difftool:
$ git pr show -t 684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/684.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Ensure HAT executes with Babylon JDK images build

Reviewed-by: mcimadamore, asotona, jfumero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the code-reflection branch:

  • 590b29e: OpBuilder optimizations - part 1.

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025
@PaulSandoz PaulSandoz added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2025

Webrevs

Copy link
Member

@asotona asotona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely now.

Copy link
Member

@jjfumero jjfumero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build and unit-tests passing.

@PaulSandoz
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

Going to push as commit 1fd0917.
Since your change was applied there has been 1 commit pushed to the code-reflection branch:

  • 590b29e: OpBuilder optimizations - part 1.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2025
@openjdk openjdk bot closed this Nov 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@PaulSandoz Pushed as commit 1fd0917.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the hat-add-modules-code branch November 21, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants