-
Notifications
You must be signed in to change notification settings - Fork 31
Ensure HAT executes with Babylon JDK images build #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure HAT executes with Babylon JDK images build #684
Conversation
|
👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into |
|
@PaulSandoz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
asotona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely now.
jjfumero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, build and unit-tests passing.
|
/integrate |
|
@PaulSandoz Pushed as commit 1fd0917. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
HAT only executes correctly with a Babylon JDK exploded build, and fails with an images build.
We need to declare the runtime argument
--add-modules jdk.incubator.code.Also removed an
--add-exportsargument which no longer seems to be required.Progress
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/684/head:pull/684$ git checkout pull/684Update a local copy of the PR:
$ git checkout pull/684$ git pull https://git.openjdk.org/babylon.git pull/684/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 684View PR using the GUI difftool:
$ git pr show -t 684Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/684.diff
Using Webrev
Link to Webrev Comment