8271870: G1: Add objArray splitting when scanning object with evacuation failure

[tschatzl]

Hi all,

please review this change that makes the object iteration path for evacuation failed objects the same as the one for regular objects (and indeed make both use the same code).

This has been made possible with the refactoring of object array task queues.

At the same time this also covers JDK-8271871.

Testing: tier1-5, some perf testing with no differences

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8271870: G1: Add objArray splitting when scanning object with evacuation failure (Enhancement - P4)
• JDK-8271871: G1 does not try to deduplicate objects that failed evacuation (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) Review applies to e5ce3984
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24222/head:pull/24222
$ git checkout pull/24222

Update a local copy of the PR:
$ git checkout pull/24222
$ git pull https://git.openjdk.org/jdk.git pull/24222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24222

View PR using the GUI difftool:
$ git pr show -t 24222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24222.diff

Using Webrev

Link to Webrev Comment

[tschatzl]

/issue add JDK-8271871

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271870: G1: Add objArray splitting when scanning object with evacuation failure
8271871: G1 does not try to deduplicate objects that failed evacuation

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

• 296d9d6: 8353345: C2 asserts because maskShiftAmount modifies node without deleting the hash
• 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
• b263292: 8353484: JFR: Simplify EventConfiguration
• ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
• f7a94fe: 8352585: Add special case handling for Float16.max/min x86 backend
• 9c5ed23: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• 00a038e: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead
• bd74922: 8338675: javac shouldn't silently change .jar files on the classpath
• 8d3d1d4: 8353058: [PPC64] Some IR framework tests are failing after JDK-8352595
• b01026a: 8353325: Rewrite appcds/methodHandles test cases to use CDSAppTester
• ... and 58 more: https://git.openjdk.org/jdk/compare/d4d18350f367a18813d0d418169e852c1530418e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl
Adding additional issue to issue list: 8271871: G1 does not try to deduplicate objects that failed evacuation.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (21cc754a)
• 00: Full (e5ce3984)

[walulyai]

LGTM!

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit 64b691a.
Since your change was applied there have been 70 commits pushed to the master branch:

• b428cda: 8349686: [s390x] C1: Improve Class.isInstance intrinsic
• 70e3250: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
• 296d9d6: 8353345: C2 asserts because maskShiftAmount modifies node without deleting the hash
• 3ceabf0: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call
• b263292: 8353484: JFR: Simplify EventConfiguration
• ffca4f2: 8353264: ZGC: Windows heap unreserving is broken
• f7a94fe: 8352585: Add special case handling for Float16.max/min x86 backend
• 9c5ed23: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• 00a038e: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead
• bd74922: 8338675: javac shouldn't silently change .jar files on the classpath
• ... and 60 more: https://git.openjdk.org/jdk/compare/d4d18350f367a18813d0d418169e852c1530418e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 64b691a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.