Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311227: Add .editorconfig #24448

Closed
wants to merge 2 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 4, 2025

Alternative to #23693 for implementing JDK-8311227.

This .editorconfig file is a 1-to-1 conversion of the checks done by jcheck into .editorconfig format. I believe that is a better way to introduce an .editorconfig file into the existing JDK project.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewers without OpenJDK IDs

  • @dbriemann (no known openjdk.org user name / role)

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24448/head:pull/24448
$ git checkout pull/24448

Update a local copy of the PR:
$ git checkout pull/24448
$ git pull https://git.openjdk.org/jdk.git pull/24448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24448

View PR using the GUI difftool:
$ git pr show -t 24448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24448.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311227: Add .editorconfig

Co-authored-by: David Briemann <[email protected]>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 9a391f4: 8353278: Consolidate local file URL checks in jar: and file: URL schemes
  • 4021033: 8353659: SubmissionPublisherTest::testCap1Submit times out
  • 60fbf73: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
  • 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
  • 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
  • 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
  • 66435c2: 8352684: Opensource JInternalFrame tests - series1
  • 353e173: 8219408: Tests should handle ${} in the view of jtreg "smart action"
  • 26bb183: 8352621: MatchException from backwards incompatible change to switch expressions
  • e8c9e5c: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently
  • ... and 16 more: https://git.openjdk.org/jdk/compare/3cc43b3224efdf1a3f35fff58b993027a9e1f4ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8311227: Add .editorconfig 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace Apr 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@magicus
Copy link
Member Author

magicus commented Apr 7, 2025

/contributor add @dbriemann

@magicus magicus changed the title 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace 8311227: Add .editorconfig Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@magicus @dbriemann was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@magicus
Copy link
Member Author

magicus commented Apr 7, 2025

/contributor add David Briemann [email protected]

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@magicus
Contributor David Briemann <[email protected]> successfully added.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
Copy link
Contributor

@dbriemann dbriemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magicus
Copy link
Member Author

magicus commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit cebda92.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@magicus Pushed as commit cebda92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the editorconfig-like-jcheck branch April 7, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants