-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311227: Add .editorconfig #24448
8311227: Add .editorconfig #24448
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/contributor add @dbriemann |
@magicus Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/contributor add David Briemann [email protected] |
@magicus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/integrate |
Going to push as commit cebda92.
Your commit was automatically rebased without conflicts. |
Alternative to #23693 for implementing JDK-8311227.
This
.editorconfig
file is a 1-to-1 conversion of the checks done by jcheck into .editorconfig format. I believe that is a better way to introduce an.editorconfig
file into the existing JDK project.Progress
Issue
Reviewers
Reviewers without OpenJDK IDs
Contributors
<[email protected]>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24448/head:pull/24448
$ git checkout pull/24448
Update a local copy of the PR:
$ git checkout pull/24448
$ git pull https://git.openjdk.org/jdk.git pull/24448/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24448
View PR using the GUI difftool:
$ git pr show -t 24448
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24448.diff
Using Webrev
Link to Webrev Comment