-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300339: Run jtreg in the work dir #24452
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 60 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/integrate |
Going to push as commit bd73a06.
Your commit was automatically rebased without conflicts. |
We had a test setup failure in our distributed test system where the process running jtreg crashed. This caused the hs_err file to end up in the root of the source tree. Dropping crash files in the source tree is bad practice and makes it harder to find such files. We should change the current working directory to the work/output dir before launching jtreg to help avoid this situation in the future.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24452/head:pull/24452
$ git checkout pull/24452
Update a local copy of the PR:
$ git checkout pull/24452
$ git pull https://git.openjdk.org/jdk.git pull/24452/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24452
View PR using the GUI difftool:
$ git pr show -t 24452
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24452.diff
Using Webrev
Link to Webrev Comment