Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300339: Run jtreg in the work dir #24452

Closed
wants to merge 3 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 4, 2025

We had a test setup failure in our distributed test system where the process running jtreg crashed. This caused the hs_err file to end up in the root of the source tree. Dropping crash files in the source tree is bad practice and makes it harder to find such files. We should change the current working directory to the work/output dir before launching jtreg to help avoid this situation in the future.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24452/head:pull/24452
$ git checkout pull/24452

Update a local copy of the PR:
$ git checkout pull/24452
$ git pull https://git.openjdk.org/jdk.git pull/24452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24452

View PR using the GUI difftool:
$ git pr show -t 24452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24452.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300339: Run jtreg in the work dir

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@magicus magicus marked this pull request as ready for review April 4, 2025 15:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2025
@magicus
Copy link
Member Author

magicus commented Apr 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

Going to push as commit bd73a06.
Since your change was applied there have been 61 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2025
@openjdk openjdk bot closed this Apr 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@magicus Pushed as commit bd73a06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the cd-support-dir-jtreg branch April 8, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants