8353757: Log class should have a proper clear() method

[archiecobbs]

This is a simple refactoring to add a method Log.clear(), move ReusableLog.clear()'s clearing operations into it and invoke super.clear() instead, and add two more fields that should be included in the clear operation but were not because they were added to Log after ReusableLog.clear() was added and were missed.

A natural question: Are there any other fields in Log that should be cleared in Log.clear()? The two I've added (nsuppressederrors and nsuppressedwarns) are the only two that weren't there when ReusableLog as added, so presumably not, but it's possible.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353757: Log class should have a proper clear() method (Enhancement - P5)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24460/head:pull/24460
$ git checkout pull/24460

Update a local copy of the PR:
$ git checkout pull/24460
$ git pull https://git.openjdk.org/jdk.git pull/24460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24460

View PR using the GUI difftool:
$ git pr show -t 24460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24460.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353757: Log class should have a proper clear() method

Reviewed-by: vromero, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 705 new commits pushed to the master branch:

• e266eba: 8352972: PPC64: Intrinsify Unsafe::setMemory
• a8dfcf5: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate
• 42dc99e: 8301197: Make sure use of printf is correct and actually needed
• ... and 702 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a9d58450)
• 01: Full - Incremental (a1108ac7)
• 00: Full (e9931f6d)

[vicente-romero-oracle]

this looks good

[archiecobbs]

Thanks for the review!

[mcimadamore]

Looks good!

[archiecobbs]

/integrate

[openjdk]

Going to push as commit 5b42c46.
Since your change was applied there have been 734 commits pushed to the master branch:

• 24ff96a: 8352389: Remove incidental whitespace in pre/code content
• 257f817: 8353431: JFR: Sets to use hashmap instead of binary search as backend
• 689d73a: 8317012: Explicitly check for 32-bit word size for using libatomic with zero
• ... and 731 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

Your commit was automatically rebased without conflicts.

[openjdk]

@archiecobbs Pushed as commit 5b42c46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.