8351740: Clean up some code around initialization of encoding properties

[stuart-marks]

Some of the code that creates various encoding properties at JVM initialization time, such as file.encoding and native.encoding, could use some cleaning up. Cleanup is fairly minimal and should be mostly behavior-preserving. Changes include the following:

• In the java_props.h and java_props_md.c files, add documentation and asserts that the sprops.encoding and sprops.sun_jnu_encoding members are always set to non-NULL by the platform-specific code.

• In SystemProps.java, remove a null check that is now extraneous based on the above assertion.

• In SystemProps.java, rearrange logic (with no behavior change) around handling of the "COMPAT" value for the file.encoding property.

• In SystemProps.Raw, rename the platform properties array index from _file_encoding_NDX to _native_encoding_NDX.

• In SystemProps.Raw.cmdProperties(), adjust the HashMap size computation. This should actually avoid resizing of the HashMap (unlike the earlier code).

• Adjust various comments in several places for clarity and correctness.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351740: Clean up some code around initialization of encoding properties (Enhancement - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24463/head:pull/24463
$ git checkout pull/24463

Update a local copy of the PR:
$ git checkout pull/24463
$ git pull https://git.openjdk.org/jdk.git pull/24463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24463

View PR using the GUI difftool:
$ git pr show -t 24463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24463.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351740: Clean up some code around initialization of encoding properties

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

• e3f26b0: 8351319: AOT cache support for custom class loaders broken since JDK-8348426
• 4954a33: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint
• 4a242e3: 8354213: Restore pointless unicode characters to ASCII
• ... and 154 more: https://git.openjdk.org/jdk/compare/e6fe2490bc48acf01ccf81b38d578d20ed09f238...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@stuart-marks The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e8f3d35e)
• 00: Full (f5ba54f9)

[naotoj]

Thanks for the clean-up. Changing the index name from _file_encoding_NDX to _native_encoding_NDX really helps.

[naotoj]

LGTM