8353686: Optimize Math.cbrt for x86 64 bit platforms #24470
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to implement an x86_64 intrinsic for java.lang.Math.cbrt() using libm.
The results of all tests posted below were captured with an Intel® Xeon 6761P using OpenJDK v25-b15 as the baseline version.
For performance data collected with the built in cbrt micro-benchmark, see the table below. Each result is the mean of 8 individual runs. Overall, the intrinsic provides a performance uplift of 41%.
Finally, the
jtreg:test/jdk/java/lang/Math/CubeRootTests.java
test passed with the changes.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24470/head:pull/24470
$ git checkout pull/24470
Update a local copy of the PR:
$ git checkout pull/24470
$ git pull https://git.openjdk.org/jdk.git pull/24470/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24470
View PR using the GUI difftool:
$ git pr show -t 24470
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24470.diff