Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353686: Optimize Math.cbrt for x86 64 bit platforms #24470

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

missa-prime
Copy link
Contributor

@missa-prime missa-prime commented Apr 6, 2025

The goal of this PR is to implement an x86_64 intrinsic for java.lang.Math.cbrt() using libm.

The results of all tests posted below were captured with an Intel® Xeon 6761P using OpenJDK v25-b15 as the baseline version.

For performance data collected with the built in cbrt micro-benchmark, see the table below. Each result is the mean of 8 individual runs. Overall, the intrinsic provides a performance uplift of 41%.

Benchmark Throughput with baseline (op/s) Throughput with intrinsic (op/s) Speedup
MathBench.cbrt 148242 209122 1.41x

Finally, the jtreg:test/jdk/java/lang/Math/CubeRootTests.java test passed with the changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353686: Optimize Math.cbrt for x86 64 bit platforms (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24470/head:pull/24470
$ git checkout pull/24470

Update a local copy of the PR:
$ git checkout pull/24470
$ git pull https://git.openjdk.org/jdk.git pull/24470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24470

View PR using the GUI difftool:
$ git pr show -t 24470

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24470.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2025

👋 Welcome back missa-prime! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 6, 2025

@missa-prime The following labels will be automatically applied to this pull request:

  • core-libs
  • graal
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@missa-prime missa-prime force-pushed the user/missa-prime/cbrt branch from d1a152d to 30c48cb Compare April 6, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant