-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8353659: SubmissionPublisherTest::testCap1Submit times out #24473
Conversation
👋 Welcome back vklang! A progress list of the required criteria for merging this PR into |
@viktorklang-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman @DougLea This is a draft PR for now. I need to run some additional tier-testing in order to promote to a "real" PR. |
@viktorklang-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@AlanBateman @DougLea Testing-wise this is ready for review and, hopefully, integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for tracking this down.
/integrate |
Going to push as commit 4021033.
Your commit was automatically rebased without conflicts. |
@viktorklang-ora Pushed as commit 4021033. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR reverts the deactivation changes of the updates to FJP introduced in JDK-8319447.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24473/head:pull/24473
$ git checkout pull/24473
Update a local copy of the PR:
$ git checkout pull/24473
$ git pull https://git.openjdk.org/jdk.git pull/24473/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24473
View PR using the GUI difftool:
$ git pr show -t 24473
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24473.diff
Using Webrev
Link to Webrev Comment