-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8348611: Eliminate DeferredLintHandler and emit warnings after attribution #24584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
4fcc612
Track source end positions of declarations that support @SuppressWarn…
archiecobbs e235228
Add end position for variables coming from variableDeclaratorId().
archiecobbs daacc44
Fix bug where some warnings didn't have a source file position.
archiecobbs f5be4ca
Remove no-longer-needed workaround.
archiecobbs 99b3c35
Remove unused code.
archiecobbs 8027224
Merge branch 'JDK-8353221' into JDK-8352731
archiecobbs 0f85a24
Add missing variable decl end position.
archiecobbs e9931f6
Add new method Log.clear().
archiecobbs a1108ac
Invoke Log.useSource() before recursing into attribution.
archiecobbs 2344716
Revert accidentally included unrelated changes.
archiecobbs a9d5845
Reset the DiagnosticHandler stack in clear().
archiecobbs 0127028
Refactoring/cleanup for handling of ending positions.
archiecobbs f831a10
Add field LintCategory.annotationSuppression.
archiecobbs 0791ff7
Refactor handling of DEPRECATION_ON_IMPORT via new flag Check.importS…
archiecobbs c491643
Bump copyright.
archiecobbs 5bb0b11
Add "not yet" comment to TEXT_BLOCKS.
archiecobbs 2e68d7a
Small cleanups relating to Log.DiagnosticHandler.
archiecobbs dc3b98c
Add comment per review suggestion.
archiecobbs 0a9f5e0
Merge branch 'JDK-8354090' into JDK-8348611
archiecobbs 6852ed1
Merge branch 'JDK-8329951' into JDK-8348611
archiecobbs 004cc5f
Merge branch 'JDK-8352731' into JDK-8348611
archiecobbs 20257a5
Merge branch 'JDK-8354071' into JDK-8348611
archiecobbs 0c98da7
Merge branch 'JDK-8350212' into JDK-8348611
archiecobbs 6ff5e73
Merge branch 'JDK-8354216' into JDK-8348611
archiecobbs de2d3ab
Initial prototype for JDK-8348611.
archiecobbs 7771061
Merge remote-tracking branch 'upstream/master' into JDK-8348611
archiecobbs e67b47b
Add test for retroactive @SuppressWarnings("dangling-doc-comments") b…
archiecobbs d0954d4
Remove another unnecessary call to Check.setLint().
archiecobbs f2bab52
Merge branch 'JDK-8354447' into JDK-8348611
archiecobbs 4d870e0
Revert unintentional change in the behavior of the "dangling-doc-comm…
archiecobbs fbca756
Update regression test expected output after previous commit.
archiecobbs d855d51
Remove some obsolete invocations of Check.setLint() and unused imports.
archiecobbs 3f4b5f1
Update ThisEscapeAnalyzer to use LintMapper for Lint calculation.
archiecobbs f2d2755
Some refactoring & cleanups for ThisEscapeAnalyzer.
archiecobbs 3a6dd76
Some refactoring to make code clearer.
archiecobbs 7c298b4
More cleanups & refactoring.
archiecobbs d19ad6f
Move LintMapper from "util" to "code" sub-package.
archiecobbs 5f003d1
Update copyrights.
archiecobbs 67ce889
Merge branch 'JDK-8350212' into JDK-8348611
archiecobbs 9394f7e
Merge branch 'master' into JDK-8348611
archiecobbs 3cd938a
Cleanups.
archiecobbs 5ef9606
Refactor ThisEscapeAnalyzer to correct bug in suppression logic.
archiecobbs b8c3dcd
Merge branch 'JDK-8355753' into JDK-8348611
archiecobbs ddb0d4e
Update copyrights.
archiecobbs a356d88
Merge branch 'master' into JDK-8348611 to fix conflict.
archiecobbs 81a25ca
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs 102beb5
Merge branch 'master' into JDK-8348611
archiecobbs 348cf0e
Merge branch 'master' into JDK-8350212 to fix conflict.
archiecobbs 563a143
Merge branch 'master' into JDK-8348611
archiecobbs a63e3d6
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs b10fb8b
Merge branch 'master' into JDK-8355753
archiecobbs 65e2679
Add additional tests for warnings generated from fields.
archiecobbs 0122a0e
Merge branch 'master' into JDK-8350212
archiecobbs 0898c55
Revert TreeInfo.endPos() refactoring except for "bracePos" renaming.
archiecobbs f79e35f
Remove extraneous semicolons.
archiecobbs 67f8cd1
Merge branch 'master' into JDK-8348611 to fix conflict.
archiecobbs 9a15a63
Merge branch 'JDK-8355753' into JDK-8348611
archiecobbs 205f77e
Update EndPosTable.replaceTree() to handle a new node equal to null.
archiecobbs a62ebc6
Merge branch 'JDK-8350212' into JDK-8348611
archiecobbs 6ab327b
Merge branch 'master' into JDK-8348611
archiecobbs 7f062a6
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs 2c4d228
Merge branch 'master' into JDK-8348611
archiecobbs 16debaa
Small refactoring to utilize new method Options.isExplicitlyDisabled().
archiecobbs 75d9edf
Refactor MandatoryWarningHandler to just be an aggregator.
archiecobbs cde1f5e
Revert PR #24600 (for JDK-8354447) from this branch so it's not a dep…
archiecobbs 24df3a2
Add comment to regression test.
archiecobbs b7adf7c
Revert regression test change that is no longer necessary.
archiecobbs 5069bf2
Restore behavior when both -Xlint:options and -Xlint:-options are given.
archiecobbs 8dcea70
No need for /nodynamiccopyright/ with this test.
archiecobbs 38febc6
Merge branch 'JDK-8359596' into JDK-8348611
archiecobbs 9e78831
Ensure that "-Xlint:none" still works for the affected warnings.
archiecobbs 34ab5ed
Merge branch 'JDK-8359596' into JDK-8348611
archiecobbs 982d2b8
Merge branch 'MandatoryWarningCleanup' into JDK-8348611 to fix confli…
archiecobbs 81670b1
Apply some review suggestions.
archiecobbs f01f19d
Cleanups per review comments.
archiecobbs ebc55e5
Merge branch 'JDK-8359596' into JDK-8348611
archiecobbs 2ebeefc
Add DiagnosticFlag support to compiler.properties and put AGGREGATE t…
archiecobbs 95b368f
Move (most) SOURCE_LEVEL flags into compiler.properties.
archiecobbs f383205
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs e8c6d2b
Merge branch 'MandatoryWarningCleanup' into JDK-8348611
archiecobbs 94cda82
Merge branch 'master' into MandatoryWarningCleanup
archiecobbs a1b89be
Merge branch 'MandatoryWarningCleanup' into JDK-8348611
archiecobbs 8d822b1
Remove assumptions about mandatoryness from the MandatoryWarningAggre…
archiecobbs 2b16d65
Address review suggestions.
archiecobbs 5086267
Merge branch 'MandatoryWarningCleanup' into JDK-8348611
archiecobbs ec02990
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs 9432be0
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs c9b0d10
Merge branch 'master' into JDK-8348611 to fix conflicts.
archiecobbs 91202f7
Add DEFAULT_ENABLED flags to fix some mandatory warnings.
archiecobbs f3f63f9
Merge branch 'master' into JDK-8348611
archiecobbs d4322d9
Address a couple of review comments.
archiecobbs f65e195
Refactor LintMapper to clean up internal type hierarchy per review.
archiecobbs 147cb2d
More refactoring to simplify LintMapper per review.
archiecobbs 6a1289e
More simplification of LintMapper per review suggestions.
archiecobbs d1adde4
More simplification of LintMapper per review suggestions.
archiecobbs 7fca4a0
Remove an unnecessary field.
archiecobbs 18eaa8e
Merge branch 'master' into JDK-8348611 to fix conflict.
archiecobbs 1f1247b
Remove unused field from "LintRange" record.
archiecobbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
176 changes: 0 additions & 176 deletions
176
src/jdk.compiler/share/classes/com/sun/tools/javac/code/DeferredLintHandler.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it a lot that now there's "just warnings". It took a while to see this more clearly, but once you see it you can't unsee it :-)