8354196: C2: reorder and capitalize phase definition

[mhaessig]

This PR performs some cleanup and formatting around the phase definitions in C2:

• the phase descriptions are capitalized according to the MLA Handbook title case rules,
• the phases are reordered to be more or less in the order of execution or occurrence in the code,
• the definitions in phasetype.hpp and CompilePhase.java are synced,
• CompilePhase.java is aligned for better readability.

This change was tested on:

• Github Actions
• tier1 plus some Oracle internal testing

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354196: C2: reorder and capitalize phase definition (Enhancement - P5)

Reviewers

• Marc Chevalier (@marc-chevalier - Committer) Review applies to 54dbaabf
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25778/head:pull/25778
$ git checkout pull/25778

Update a local copy of the PR:
$ git checkout pull/25778
$ git pull https://git.openjdk.org/jdk.git pull/25778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25778

View PR using the GUI difftool:
$ git pr show -t 25778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25778.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354196: C2: reorder and capitalize phase definition

Reviewed-by: chagedorn, mchevalier

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• e7f63ba: 8359327: Incorrect AVX3Threshold results into code buffer overflows on APX targets
• a0fb35c: 8359272: Several vmTestbase/compact tests timed out on large memory machine
• 032ead1: 8358483: G1: Remove G1HeapRegionManager::num_available_regions
• ... and 41 more: https://git.openjdk.org/jdk/compare/9586817cea3f1cad8a49d43e9106e25dafa04765...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@marc-chevalier, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9f3676e4)
• 00: Full (54dbaabf)

[marc-chevalier]

More consistent, nice! Everything is still there, or seems to make sense (like I couldn't find anything lost while moving around). Not very sure of the order of phases, but it seems good.

Tip for other reviewers: commit by commit is easier and clearer in this PR.

[chhagedorn]

Thanks for cleaning it up, looks good!

[chhagedorn]

Not sure if this should be also part of this change but we might want to consider "Iter GVN" -> IGVN (same for left hand sides of flags().

[mhaessig]

I will comment on JDK-8319599 to propose it.

[chhagedorn]

Sounds good, thanks!

[mhaessig]

Thank you @marc-chevalier & @chhagedorn for your quick reviews!

[mhaessig]

/integrate

[openjdk]

@mhaessig
Your change (at version 9f3676e) is now ready to be sponsored by a Committer.

[chhagedorn]

/sponsor

[openjdk]

Going to push as commit b4c4496.
Since your change was applied there have been 49 commits pushed to the master branch:

• b5334fe: 8314180: Disable XPath in XML Signatures
• e8ef93a: 8357782: JVM JIT Causes Static Initialization Order Issue
• 25b22c9: 8358602: JFR: Annotations in jdk.jfr package should not use "not null" in specification
• ... and 46 more: https://git.openjdk.org/jdk/compare/9586817cea3f1cad8a49d43e9106e25dafa04765...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn @mhaessig Pushed as commit b4c4496.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.