8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection

[dermotb]

Replaced programmatic check for the OS platform (which threw a Skipped exception) with JTreg @requires.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection (Bug - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25781/head:pull/25781
$ git checkout pull/25781

Update a local copy of the PR:
$ git checkout pull/25781
$ git pull https://git.openjdk.org/jdk.git pull/25781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25781

View PR using the GUI difftool:
$ git pr show -t 25781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25781.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @dermotb, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dermotb" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@dermotb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359127: Amend java/nio/channels/DatagramChannel/PromiscuousIPv6.java to use @requires for OS platform selection

Reviewed-by: djelinski, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 417f8ec: 8359224: G1: Incorrect size unit in logging of G1CollectedHeap::alloc_archive_region
• 57cabc6: 8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently
• b4c4496: 8354196: C2: reorder and capitalize phase definition
• ... and 54 more: https://git.openjdk.org/jdk/compare/0582bd290d5a8b6344ae7ada36492cc2f33df050...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@djelinski, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dermotb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dermotb]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[sendaoYan]

The copyright year should be updated from 2023 to 2025.

[mlbridge]

Webrevs

• 01: Full - Incremental (6831ea37)
• 00: Full (e21548b0)

[serhiysachkov]

LGTM

[dfuch]

I have the same remark than @mahendrachhipa, otherwise LGTM.

[openjdk]

⚠️ @dermotb the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8359127
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

[dermotb]

/integrate

[openjdk]

@dermotb
Your change (at version 6831ea3) is now ready to be sponsored by a Committer.

[msheppar]

/sponsor

[openjdk]

Going to push as commit 78b1360.
Since your change was applied there have been 57 commits pushed to the master branch:

• 417f8ec: 8359224: G1: Incorrect size unit in logging of G1CollectedHeap::alloc_archive_region
• 57cabc6: 8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently
• b4c4496: 8354196: C2: reorder and capitalize phase definition
• ... and 54 more: https://git.openjdk.org/jdk/compare/0582bd290d5a8b6344ae7ada36492cc2f33df050...master

Your commit was automatically rebased without conflicts.

[openjdk]

@msheppar @dermotb Pushed as commit 78b1360.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.