8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees

[plummercj]

JDK-8333117 removed support for non-local debuggees, so now only local debuggees are supported. However, there are now a lot of references to the "local" debuggee mode which are not necessary because "local" is implied. These references are in comments and API names and should be removed.

Also, after JDK-8333117, DebugeeProcess no longer needs to be considered abstract. It has no abstract methods.

Tested nsk/jdi, nsk/jdb, and nsk/jdwp locally. Will run tier5 CI to get better coverage.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25887/head:pull/25887
$ git checkout pull/25887

Update a local copy of the PR:
$ git checkout pull/25887
$ git pull https://git.openjdk.org/jdk.git pull/25887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25887

View PR using the GUI difftool:
$ git pr show -t 25887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25887.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 263e32b: 8358694: VM asserts if CodeCacheSegmentSize is not a power of 2
• 7d6c902: 8357726: Improve C2 to recognize counted loops with multiple casts in trip counter
• 5091057: 8351010: Test java/io/File/GetXSpace.java failed: / usable space 56380809216 > free space 14912244940
• ... and 60 more: https://git.openjdk.org/jdk/compare/982064e50ca6bbcfb7d1d619307921adc6f4fdcd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (365cc930)
• 00: Full (40624f6b)

[plummercj]

/touch

[openjdk]

@plummercj The pull request is being re-evaluated and the inactivity timeout has been reset.

[lmesnik]

Are there any reason to make it non-abstract.. Even DebugeeProcess doesn't have abstract methods, only jid/jdwp subclasses might be used.Might be left it abstract?

[plummercj]

Currently it is only used via subclasses, but that doesn't necessarily mean it couldn't be used directly. Is there a reason you want to disallow that?

[sspitsyn]

This cleanup looks good.