8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF

[prsadhuk]

There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead in Aqua LAF which updates LEAD_SELECTION_PATH_PROPERTY.....
Other L&F uses "ctrl DOWN/UP" to selectNextChangeLead/selectPreviousChangeLead but same shortcut cannot be used in mac as "ctrl DOWN" shortcut is used to display the window of current active application while "ctrl UP" is used to display all windows of all applications which allows to switch between them
so used CTRL+SHIFT+DOWN for the selectNextChangeLead CTRL+SHIFT+UP for selectPreviousChangeLead

No regression test as it can be verified through SwingSet2 demo as below..

With ctrl+shift+down

another ctrl+shift+down

Now, ctrl+shift+up

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25892/head:pull/25892
$ git checkout pull/25892

Update a local copy of the PR:
$ git checkout pull/25892
$ git pull https://git.openjdk.org/jdk.git pull/25892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25892

View PR using the GUI difftool:
$ git pr show -t 25892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25892.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3db32cd4)
• 00: Full (e5bc5d01)

[mrserb]

so used CTRL+SHIFT+DOWN for the selectNextChangeLead CTRL+SHIFT+UP for selectPreviousChangeLead

Does macOS have equivalent shortcuts for the native tree component?

No regression test as it can be verified through SwingSet2 demo as below..

I doubt anyone will run SwingSet2 in the future specifically to test this bug. The original issue was reported due to a failing test. If that test is no longer available, it would be better to create a new one to cover this case.

[prsadhuk]

I couldn't find native tree component in any native app.

Regression Test added

[DamonGuy]

I can mimic a Tree on MacOS using Finder and viewing as a List View. Looks like CTRL+SHIFT+(UP/DOWN) selects the next in that direction as well in a selection group. Here's a screenshot where I started on Apple and pressed CTRL+SHIFT+DOWN 5 times.

[DamonGuy]

Is CTRL+SHIFT+(UP/DOWN) the correct key binding here?

[prsadhuk]

Yes, seems not..No combinations seems to work in native Finder, the way lead selection does in Java
I chose that combination because there is nothing listed in macos with those options...Seems like LeadSelection change are not supported in macos.
Probably we should close this as Not an issue unless someone has other ideas.

[prsadhuk]

Seems like JDK doesnt honour ctrl+shift+up/down in Aqua as it does in Finder..We should fix that probably..

[prsadhuk]

Rasied JDK-8360462 and PR #25966