8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove

[turbanoff]

No need to call List.indexOf(Object) before List.remove(int). Instead we can call List.remove(Object) directly. It's faster and cleaner.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove (Enhancement - P5)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25931/head:pull/25931
$ git checkout pull/25931

Update a local copy of the PR:
$ git checkout pull/25931
$ git pull https://git.openjdk.org/jdk.git pull/25931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25931

View PR using the GUI difftool:
$ git pr show -t 25931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25931.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove

Reviewed-by: azvegint, serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• cf75f1f: 8358821: patch_verified_entry causes problems, use nmethod entry barriers instead
• 5252608: 8225354: serviceability/jvmti/ModuleAwareAgents/ThreadStart failed with Didn't get ThreadStart events in VM early start phase!
• f799cf1: 8360303: Remove two unused invoke files
• ... and 44 more: https://git.openjdk.org/jdk/compare/fe7ec312590ed9f70e6caad4ef454123138bbbcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

looks fine

[mlbridge]

Webrevs

• 00: Full (1b89f144)

[mrserb]

please rerun the Pre-submit tests in the GA