Skip to content

8328848: Inaccuracy in the documentation of the -group option #25959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Jun 24, 2025

This pull request contains a backport of commit f8de5bc5 from the openjdk/jdk repository.

The commit being backported was authored by Hannes Wallnöfer on 24 Jun 2025 and was reviewed by Chen Liang.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328848: Inaccuracy in the documentation of the -group option (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25959/head:pull/25959
$ git checkout pull/25959

Update a local copy of the PR:
$ git checkout pull/25959
$ git pull https://git.openjdk.org/jdk.git pull/25959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25959

View PR using the GUI difftool:
$ git pr show -t 25959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25959.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328848: Inaccuracy in the documentation of the -group option

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f8de5bc5827742dd60b8f8f4a0d3625c370af15b 8328848: Inaccuracy in the documentation of the -group option Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 24, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2025
@hns
Copy link
Member Author

hns commented Jun 25, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

Going to push as commit 80cb773.
Since your change was applied there have been 2 commits pushed to the jdk25 branch:

  • a576952: 8359024: Accessibility bugs in API documentation
  • b89f364: 8358099: PEM spec updates

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2025
@openjdk openjdk bot closed this Jun 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2025
@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@hns Pushed as commit 80cb773.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants