8357728: Avoid caching synthesized names in synthesized parameters

[liach]

Currently, fake parameters are created with "arg0" etc. strings that are retained for class file methods with no MethodParameters attribute. The original issue report observes many of these strings present in the heap. To address this issue, we can remove these eagerly created fake names, bringing their behavior in line with nameless parameters from MethodParameters attribute, such as those from inner class constructors. A unit test verifies that no name is retained in the Parameter object when the name is fake.

The original report recommends using a pool to store the arg name strings. I did not take that approach as I don't think it is very necessary; if the issue of retained fake names persist, we can update Parameter::getName to return fake names from a pool instead.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8362626 to be approved

Issues

• JDK-8357728: Avoid caching synthesized names in synthesized parameters (Enhancement - P4)(⚠️ The fixVersion in this issue is [27] but the fixVersion in .jcheck/conf is 26, a new backport will be created when this pr is integrated.)
• JDK-8362626: Avoid caching synthesized names in synthesized parameters (CSR)

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25961/head:pull/25961
$ git checkout pull/25961

Update a local copy of the PR:
$ git checkout pull/25961
$ git pull https://git.openjdk.org/jdk.git pull/25961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25961

View PR using the GUI difftool:
$ git pr show -t 25961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25961.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357728: Avoid caching synthesized names in synthesized parameters

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 02ff38f: 8363986: Heap region in CDS archive is not at deterministic address
• 902aa4d: 8372120: Add missing sound keyword to MIDI tests
• 152cd4d: 8371956: Convert OopStorage to use Atomic
• ... and 57 more: https://git.openjdk.org/jdk/compare/ad3dfaf1fc483bb2bfd5c26d76c43b8f69454cbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a79e59cd)
• 00: Full (a5a5dba4)

[jddarcy]

/csr needed

[jddarcy]

@liach , please file a CSR for the behavioral change here.

[openjdk]

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@liach please create a CSR request for issue JDK-8357728 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[liach]

Done. I have described the context in detail and moved the CSR to proposed.

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[liach]

/open

[openjdk]

@liach This pull request is now open

[JornVernee]

Looks good.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit f0afd89.
Since your change was applied there have been 66 commits pushed to the master branch:

• 0bff5f3: 8213762: Deprecate Xmaxjitcodesize
• ae4d9c2: 8371918: aarch64: Incorrect pointer dereference in TemplateInterpreterGenerator::generate_native_entry
• 0b3df48: 8372048: Performance improvement on Linux remote desktop
• ... and 63 more: https://git.openjdk.org/jdk/compare/ad3dfaf1fc483bb2bfd5c26d76c43b8f69454cbd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit f0afd89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.