Skip to content

8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) #26003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 26, 2025

Can I please get a review of this backport to JDK 25? This backports https://bugs.openjdk.org/browse/JDK-8359830 which was integrated into mainline a few minutes back #25865.

With this change it should now be possible to test JDK 25 on macOS 26 when it gets released. Java's standard os.version system property will correctly report the version as 26 on macOS 26 once this is integrated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26003/head:pull/26003
$ git checkout pull/26003

Update a local copy of the PR:
$ git checkout pull/26003
$ git pull https://git.openjdk.org/jdk.git pull/26003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26003

View PR using the GUI difftool:
$ git pr show -t 26003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26003.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2025

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8df6b2c4a355751cd8ca37cc5932be66bccaa123 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) Jun 26, 2025
@openjdk
Copy link

openjdk bot commented Jun 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jun 26, 2025
@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 26, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2025
@jaikiran
Copy link
Member Author

Thank you Roger for the review. I'll integrate this once tier1, tier2 and tier3 testing with this change in JDK 25 completes successfully.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

Going to push as commit 926c900.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2025
@openjdk openjdk bot closed this Jun 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@jaikiran Pushed as commit 926c900.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants