8284016: Normalize handshake closure names

[toxaart]

Hi, please consider the following changes:

There are many classes inherited from the HandshakeClosure class, but they do not follow the same naming convention. In this PR we address this issue, all names are normalized in the following way:

XXXDummyClassNameClosure -> XXXDummyClassNameHandshakeClosure

or

XXXDummyClassNameHandshake -> XXXDummyClassNameHandshakeClosure

or

XXXStrangeClassName -> SomewhatSimilarNameHandshakeClosure

Tested in GHA and tiers 1 - 3.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8284016: Normalize handshake closure names (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26014/head:pull/26014
$ git checkout pull/26014

Update a local copy of the PR:
$ git checkout pull/26014
$ git pull https://git.openjdk.org/jdk.git pull/26014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26014

View PR using the GUI difftool:
$ git pr show -t 26014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26014.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toxaart This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284016: Normalize handshake closure names

Reviewed-by: coleenp, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 7583a7b: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected
• e85c7d0: 8360790: G1: Improve HRRSStatsIter name
• eec1153: 8361056: Parallel: Use correct is_par argument in ScavengeRootsTask
• ... and 28 more: https://git.openjdk.org/jdk/compare/01b15bc1f961f43ae11db0c15f45763c4ec4180b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@toxaart The following labels will be automatically applied to this pull request:

• hotspot
• serviceability
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (bb95404c)
• 02: Full - Incremental (65b9ecc5)
• 01: Full - Incremental (eeb302df)
• 00: Full (fe991cc8)

[coleenp]

I found a couple of places to realign the parameters, but otherwise this looks good. I like the new naming conventions. We have a lot of handshakes now!
Were you able to build shenandoah (not built by default, need to add --enable-jvm-feature-shenandoahgc to configure)?

[toxaart]

I found a couple of places to realign the parameters, but otherwise this looks good. I like the new naming conventions. We have a lot of handshakes now! Were you able to build shenandoah (not built by default, need to add --enable-jvm-feature-shenandoahgc to configure)?

Yes, the code compiles fine with --enable-jvm-feature-shenandoahgc added.

[sspitsyn]

This looks okay in general.
I've posted several nits though.

[sspitsyn]

Thank you for the update. Looks good.

[coleenp]

Still looks good. So the pattern is that something that inherits directly from HandshakeClosure is TheThingHandshakeClosure and in the case of JVMTI further inheritance has a shorter name. Seems fine. So many handshakes!

[toxaart]

/integrate

[openjdk]

@toxaart
Your change (at version bb95404) is now ready to be sponsored by a Committer.

[dholmes-ora]

/sponsor

[openjdk]

Going to push as commit 0f1cd98.
Since your change was applied there have been 46 commits pushed to the master branch:

• 1ac7489: 8361180: Disable CompiledDirectCall verification with -VerifyInlineCaches
• 055d2ff: 8361215: Add AOT test case: verification constraint classes are excluded
• 2bff8e0: 8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F
• ... and 43 more: https://git.openjdk.org/jdk/compare/01b15bc1f961f43ae11db0c15f45763c4ec4180b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora @toxaart Pushed as commit 0f1cd98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.