-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented #26311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to regenerate the corresponding building.html using the update-build-docs
make target
doc/building.md
Outdated
corresponding Fedora release can be specified with the help of the | ||
`BASE_OS_VERSION` option (with "27" as default version). If the build is | ||
`BASE_OS_VERSION` option (with `27` as default version). If the build is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also unrelated but maybe worth fixing: the default Fedora version is 41 nowadays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 0d85899, I've removed the entire (with ... as default version)
snippet – I doubt if it is worth the effort of trying to keep up with that variable, i.e., the Fedora version. We neither share it for OL. Please let me know if you agree or disagree.
open/doc/building.md
uses the incorrectOEL6
keyword to denote the Oracle Enterprise Linux base OS distribution for Devkit – replaced it with the correct one instead, i.e.,OL
.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26311/head:pull/26311
$ git checkout pull/26311
Update a local copy of the PR:
$ git checkout pull/26311
$ git pull https://git.openjdk.org/jdk.git pull/26311/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26311
View PR using the GUI difftool:
$ git pr show -t 26311
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26311.diff
Using Webrev
Link to Webrev Comment