You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert java.nio.ByteOrder to an enum.
The class declaration is changed from public class to public enum.
Enums are Comparable so declare LITTLE_ENDIAN before BIG_ENDIAN so LITTLE_ENDIAN is less than BIG_ENDIAN.
The implementation is simplified, removing the constructor and explicit static fields.
Remove the override of toString; the javadoc provided by Enum is sufficient.
No changes to other classes or implementations are needed to pass Tier 1-3.
Progress
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8369130 to be approved
Issues
JDK-8362637: Convert java.nio.ByteOrder to an enum (Enhancement - P4)
JDK-8369130: Convert java.nio.ByteOrder to an enum (CSR)
Declare LITTLE_ENDIAN before BIG_ENDIAN so comparing enums LITTLE_ENDIAN is less than BIG_ENDIAN.
The implementation is simplified, removing the constructor and explicit static fields.
Remove the override of `toString`; the javadoc provided by Enum is sufficient.
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@RogerRiggs The following label will be automatically applied to this pull request:
nio
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Why do we reorder the BIG_ENDIAN and LITTLE_ENDIAN fields?
enums are Comparable and giving LITTLE_ENDIAN the 0 ordinal means it is less than BIG_ENDIAN. I don't think byte orders will be compared too often but it does avoid a surprise.
csrPull request needs approved CSR before integrationnio[email protected]rfrPull request is ready for review
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjdk
bot
added
csr
Convert java.nio.ByteOrder to an enum.
The class declaration is changed from
public classtopublic enum.Enums are
Comparableso declare LITTLE_ENDIAN before BIG_ENDIAN so LITTLE_ENDIAN is less than BIG_ENDIAN.The implementation is simplified, removing the constructor and explicit static fields.
Remove the override of
toString; the javadoc provided by Enum is sufficient.No changes to other classes or implementations are needed to pass Tier 1-3.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27657/head:pull/27657$ git checkout pull/27657Update a local copy of the PR:
$ git checkout pull/27657$ git pull https://git.openjdk.org/jdk.git pull/27657/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27657View PR using the GUI difftool:
$ git pr show -t 27657Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27657.diff
Using Webrev
Link to Webrev Comment