8369236: testlibrary_tests/ir_framework/tests/TestCompileThreshold.java timed out

[chhagedorn]

The test testlibrary_tests/ir_framework/tests/TestCompileThreshold.java times out intermittently after the timeout factor change (taking more than 120s). On my local machine, I measured around ~105-115s.

The test uses CompileThreshold=10 which is almost like Xcomp and thus quite slow. However, the purpose of this test is not to stress the compiler but actually to verify that passing CompileThreshold to the IR framework over jtreg options is properly ignored. Therefore, we can use higher CompileThreshold values and achieve the same goal. With the proposed changes, the test finishes in ~10-15s on my local machine.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8369236: testlibrary_tests/ir_framework/tests/TestCompileThreshold.java timed out (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Damon Fenacci (@dafedafe - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27667/head:pull/27667
$ git checkout pull/27667

Update a local copy of the PR:
$ git checkout pull/27667
$ git pull https://git.openjdk.org/jdk.git pull/27667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27667

View PR using the GUI difftool:
$ git pr show -t 27667

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27667.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369236: testlibrary_tests/ir_framework/tests/TestCompileThreshold.java timed out

Reviewed-by: ayang, dfenacci

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 6bec42a: 8368892: Make JEditorPane/TestBrowserBGColor.java headless
• aed9485: 8368303: AlwaysAtomicAccesses is excessively strict
• c06d680: 8362394: C2: Repeated stacked string concatenation fails with "Hit MemLimit" and other resourcing errors
• ... and 1 more: https://git.openjdk.org/jdk/compare/e783c524c17e1d1a3fff4b6370e222134e66edc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (51ae099c)

[dafedafe]

The fix looks good to me. Thanks @chhagedorn!

[chhagedorn]

Thanks @albertnetymk and @dafedafe for your reviews!