Skip to content

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 7, 2025

Trivial removing dead code.

Test: tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369277: Remove unused CodeCacheUnloadingTask::_num_workers (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27671/head:pull/27671
$ git checkout pull/27671

Update a local copy of the PR:
$ git checkout pull/27671
$ git pull https://git.openjdk.org/jdk.git pull/27671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27671

View PR using the GUI difftool:
$ git pr show -t 27671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27671.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2025

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369277: Remove unused CodeCacheUnloadingTask::_num_workers

Reviewed-by: shade, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8369277 8369277: Remove unused CodeCacheUnloadingTask::_num_workers Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@albertnetymk The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2025

Webrevs

_phase(phase),
_unloading_occurred(unloading_occurred),
_code_cache_task(num_workers, unloading_occurred),
_code_cache_task(unloading_occurred),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShenandoahClassUnloadingTask constructor argument num_workers is also unused now?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2025
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

Going to push as commit c669506.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 8, 2025
@openjdk openjdk bot closed this Oct 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@albertnetymk Pushed as commit c669506.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the remove-field-trivial branch October 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants